Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SiYuan.app v1.1.83 #105147

Merged
merged 3 commits into from May 5, 2021
Merged

Add SiYuan.app v1.1.83 #105147

merged 3 commits into from May 5, 2021

Conversation

hkunzhe
Copy link
Contributor

@hkunzhe hkunzhe commented May 5, 2021

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

After making all changes to a cask, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --new-cask {{cask_file}} worked successfully.
  • brew install --cask {{cask_file}} worked successfully.
  • brew uninstall --cask {{cask_file}} worked successfully.

@vitorgalvao
Copy link
Member

Fantastic first contribution! Thank you, and welcome.

@vitorgalvao vitorgalvao enabled auto-merge (squash) May 5, 2021 12:13
@hkunzhe hkunzhe requested a review from vitorgalvao May 5, 2021 12:29
@vitorgalvao vitorgalvao merged commit 5167c99 into Homebrew:master May 5, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants