Skip to content

range跨多个文本节点,以支持带文本样式和超链接的搜索 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

iamqiz
Copy link

@iamqiz iamqiz commented Apr 17, 2024

No description provided.

@TCOTC TCOTC added the enhancement New feature or request label Apr 17, 2024
@TCOTC TCOTC merged commit 4b8e69a into TCOTC:main Apr 17, 2024
@TCOTC
Copy link
Owner

TCOTC commented Apr 17, 2024

感谢贡献!

@TCOTC
Copy link
Owner

TCOTC commented Apr 17, 2024

@iamqiz 好像在 querySelectorAll 换成 querySelector 之后,分屏时无法搜索到每个页签中的内容了,能改进吗? #13

@iamqiz
Copy link
Author

iamqiz commented Apr 18, 2024

@TCOTC 分屏增加一个窗口, 你希望分屏情况下一个搜索框能搜索多个窗口下的文档?
我的想法是 ,一个窗口对应一个搜索框, 某搜索框负责搜索所在窗口下当前激活的文档

@TCOTC
Copy link
Owner

TCOTC commented Apr 18, 2024

@iamqiz

一个窗口对应一个搜索框, 某搜索框负责搜索所在窗口下当前激活的文档

原本确实是一个窗口对应一个搜索框,但合并完这个 PR 之后所有的搜索框都只能用来搜索最左上角的那个页签了,所以我在 #12 改为了只打开一个输入框

分屏情况下一个搜索框能搜索多个窗口下的文档

我感觉这个方案应该是比较方便的。我分屏开4个页签的时候就感觉输入框太多了,一个个关掉又麻烦

@iamqiz
Copy link
Author

iamqiz commented Apr 18, 2024

@TCOTC > 分屏情况下一个搜索框能搜索多个窗口下的文档

问题来了,
1 搜索框放哪个窗口里? 感觉没有一个合适的位置
2 多个窗口下,有时用户难以分辨哪个窗口是当前激活的, 所以用户在搜索时需要先点击要搜索的文档使其激活,然后搜索框才知道要搜哪个文档, 如果一个窗口对应一个搜索框,那么搜索框只需要搜索其所在窗口的当前文档,用户肉眼就能确定的

@TCOTC
Copy link
Owner

TCOTC commented Apr 18, 2024

@iamqiz 不管了,反正 #14 已经合并了

@iamqiz iamqiz deleted the dev1 branch April 18, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants