Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggestion] ctrl+g behavior #137

Closed
jakekwak opened this issue Feb 12, 2020 · 4 comments
Closed

[suggestion] ctrl+g behavior #137

jakekwak opened this issue Feb 12, 2020 · 4 comments
Assignees
Milestone

Comments

@jakekwak
Copy link
Contributor

jakekwak commented Feb 12, 2020

ctrl+g like ctrl+b, ctrl+i, and ctrl+s

exampe : ctrl+g, test, ctrl+g, test test

inline code

@jakekwak
Copy link
Contributor Author

toolbarEvents.ts

line 105

        if (tagName === "S" || tagName === "STRONG" || tagName === "EM" || tagName === "CODE") {
            let insertHTML = "";
            if (text.substr(0, offset) !== "" && text.substr(0, offset) !== Constants.ZWSP || previousHTML) {
                insertHTML = `<${tagName}>${lastTagName}${previousHTML}${text.substr(0, offset)}${lastEndTagName}</${tagName}>`;
            }
            if ((commandName === "bold" && tagName === "STRONG") ||
                (commandName === "italic" && tagName === "EM") ||
                (commandName === "inline-code" && tagName === "CODE") ||
                (commandName === "strikeThrough" && tagName === "S")) {
                insertHTML += `${lastTagName}${Constants.ZWSP}<wbr>${lastEndTagName}`;
                jump = true;

line 302

            if (range.toString() === "" && (commandName === "bold" || commandName === "italic" 
                || commandName === "strikeThrough" || commandName === "inline-code")) {
                let tagName = "strong";
                if (commandName === "italic") {
                    tagName = "em";
                } else if (commandName === "strikeThrough") {
                    tagName = "s";
                } else if (commandName === "inline-code")   {
                    tagName = "code";
                }

line 3 commnet
line 170-176 comment
line 221-235 comment

@Vanessa219 Vanessa219 self-assigned this Feb 24, 2020
@Vanessa219 Vanessa219 added this to the 2.2 milestone Feb 24, 2020
@Vanessa219
Copy link
Owner

Thx, we will fix it in 2.2.x.

@jakekwak
Copy link
Contributor Author

ctrl+g

@Vanessa219
Copy link
Owner

toggle code, select all is not good?

stevapple pushed a commit to stevapple/vditor that referenced this issue Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants