Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[suggestion] ctrl+shift+j toggle checked #145

Closed
jakekwak opened this issue Feb 14, 2020 · 2 comments
Closed

[suggestion] ctrl+shift+j toggle checked #145

jakekwak opened this issue Feb 14, 2020 · 2 comments
Assignees
@Vanessa219
Labels
改进功能
Milestone
2.2

Comments

@jakekwak
Copy link
Contributor

ctrl+j, test, enter,
ctrl+j,test, ctrl+j, enter,
test, ctrl+j

ctrl+j: toggle
ctrl+j: unchecked and ctrl+shift+j: checked

ctrlj
@Vanessa219 Vanessa219 changed the title [suggestion] ctrl+j [suggestion] ctrl+shift+j toggle checked Feb 20, 2020
@Vanessa219 Vanessa219 self-assigned this Feb 20, 2020
@Vanessa219 Vanessa219 added this to the 2.2 milestone Feb 20, 2020
@Vanessa219 Vanessa219 changed the title [suggestion] ctrl+shift+j toggle checked [suggestion] ctrl+shift toggle checked Feb 20, 2020
@Vanessa219 Vanessa219 changed the title [suggestion] ctrl+shift toggle checked [suggestion] ctrl+shift+j toggle checked Feb 20, 2020
Vanessa219 added a commit that referenced this issue Feb 20, 2020
@Vanessa219
🎨 #145
6c1fdc1
@jakekwak
Copy link
Contributor Author

@Vanessa219 Could you tell me where is the code handling ctrl+j?
I can not find how to bind ctrl+j key to toolbar button at the source code.
When I commented the hotkey ctrl+b and ctrl+j at util/options.ts, ctrl+b is still working but ctrl+j is not.

@Vanessa219
Copy link
Owner

I can not reproduce, see https://github.com/Vanessa219/vditor/blob/master/src/ts/util/editorCommenEvent.ts#L142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vanessa219 Vanessa219

Labels
改进功能
Projects
None yet
Milestone
2.2
Development

No branches or pull requests
2 participants
@Vanessa219 @jakekwak