Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List+blockquote #176

Closed
jakekwak opened this issue Feb 24, 2020 · 7 comments
Closed

List+blockquote #176

jakekwak opened this issue Feb 24, 2020 · 7 comments
Assignees
Milestone

Comments

@jakekwak
Copy link
Contributor

problem:
list+blockquote

list+hr

expected:
list+blockquote1

@Vanessa219 Vanessa219 self-assigned this Feb 25, 2020
@Vanessa219 Vanessa219 added this to the 2.2 milestone Feb 25, 2020
@jakekwak
Copy link
Contributor Author

ctrl+l, test, shift+enter, ctrl+.
Feb-25-2020 05-49-49

Is it correct? shift+enter instead of enter.
ctrl+l, test, shift+enter, >, test, enter, backspace, shift+enter,
test, enter, backspace, ctrl+shift+., ctrl+shift+.
Feb-25-2020 05-50-32

@Vanessa219
Copy link
Owner

I think it's ok, it's better than using blockquote for the wrapping list

shift+enter is different from enter
enter will generate a tag p, ctrl+shift+. change the block element to blockquote. shift+enter is a tag p, and can not insert blockquote.

@jakekwak
Copy link
Contributor Author

Ok.
Which one is right?
ctrl+l, test, shift+enter, ctrl+.
blockquote inside list
or
blockquote inside list1

I expected like when ctrl+shift+.
blockquote inside list2

and the event.key at mac is . but > at windows.
event

@Vanessa219
Copy link
Owner

blockquote is a block element, shift + enter cannot create a new block element, and therefore cannot create a new blockquote.
It is recommended that you press shift+enter, shift+enter, ctrl+.

thanks for your reminder

@Vanessa219
Copy link
Owner

windows can not support ctrl+>, maybe change hotkey 😢

@jakekwak
Copy link
Contributor Author

use both like

(blockElement && isCtrl(event) && event.shiftKey && (event.key === "." || event.key === ">"))

@Vanessa219
Copy link
Owner

Thanks, I have refactored it to ctrl+: and ctrl+shift+:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants