Skip to content

GFM Example 31 #180

Closed
Closed
@jakekwak

Description

@jakekwak
Contributor

https://github.github.com/gfm/#example-31

- Foo
- * * *

Example31

- ***
* ---

Is there a reason to handle === in isHrMD and * --- in SpinVditorDOM?
=== is changed after typing enter, but * --- is changed without enter.
I think enter is better.

Activity

88250

88250 commented on Feb 26, 2020

@88250
Collaborator

Is there a reason to handle === in isHrMD and * --- in SpinVditorDOM?

Because parsing <li> is complicated, there are many rules to follow by, so we need Lute to handle it. Instead, parsing <hr> is simpler, and Vditor needs to decide when to parse. For example, when the user types a space, some times need to parse but some times need not be.

When needs to parse is the core user experience, we should focus on it always. Our guideline is instant as much as possible. The Setext Heading (--- and ===) support just improved, maybe rendered without typing enter in the future.

Thank you for these suggestions, we keep moving!

added a commit that references this issue on Feb 26, 2020
changed the title [-]Example 31[/-] [+]GFM Example 31[/+] on Feb 26, 2020
self-assigned this
on Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @88250@jakekwak

      Issue actions

        GFM Example 31 · Issue #180 · Vanessa219/vditor