Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GFM Example 31 #180

Closed
jakekwak opened this issue Feb 25, 2020 · 1 comment
Closed

GFM Example 31 #180

jakekwak opened this issue Feb 25, 2020 · 1 comment
Assignees

Comments

@jakekwak
Copy link
Contributor

jakekwak commented Feb 25, 2020

https://github.github.com/gfm/#example-31

- Foo
- * * *

Example31

- ***
* ---

Is there a reason to handle === in isHrMD and * --- in SpinVditorDOM?
=== is changed after typing enter, but * --- is changed without enter.
I think enter is better.

@88250
Copy link
Collaborator

88250 commented Feb 26, 2020

Is there a reason to handle === in isHrMD and * --- in SpinVditorDOM?

Because parsing <li> is complicated, there are many rules to follow by, so we need Lute to handle it. Instead, parsing <hr> is simpler, and Vditor needs to decide when to parse. For example, when the user types a space, some times need to parse but some times need not be.

When needs to parse is the core user experience, we should focus on it always. Our guideline is instant as much as possible. The Setext Heading (--- and ===) support just improved, maybe rendered without typing enter in the future.

Thank you for these suggestions, we keep moving!

@88250 88250 changed the title Example 31 GFM Example 31 Feb 26, 2020
@88250 88250 self-assigned this Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants