Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate CSS(render.html) #517

Closed
jakekwak opened this issue Jun 29, 2020 · 13 comments
Closed

Duplicate CSS(render.html) #517

jakekwak opened this issue Jun 29, 2020 · 13 comments
Assignees
@Vanessa219
Labels
修复缺陷
Milestone
3.3

Comments

@jakekwak
Copy link
Contributor

Is there any option not to include CSS? (below <style>.... </style>)

Screen Shot 2020-06-29 at 8 58 47 AM
@Vanessa219
Copy link
Owner

render.html has not this css

@jakekwak
Copy link
Contributor Author

@Vanessa219 it is automatically added when I checked the chrome developer.

@Vanessa219
Copy link
Owner

this is added by webpack, you just import xxx.css is OK.

@jakekwak
Copy link
Contributor Author

When adding the custom css(xxx.css), this will be inserted at the below, it causing a crash.

@Vanessa219
Copy link
Owner

This is a development method, we can change the setTheme API and extend markdown.theme.

@jakekwak
Copy link
Contributor Author

Ok, thanks

@Vanessa219 Vanessa219 mentioned this issue Jun 30, 2020
Closed
@Vanessa219
Copy link
Owner

#519

@jakekwak
Copy link
Contributor Author

no duplicate at demo/render.js

// import '../src/assets/scss/index.scss'

@Vanessa219
Copy link
Owner

Sorry, what do you mean?

@jakekwak
Copy link
Contributor Author

jakekwak commented Jul 1, 2020

I found the reason of duplicate css

@Vanessa219
Copy link
Owner

which css is duplicate?

@jakekwak
Copy link
Contributor Author

jakekwak commented Jul 1, 2020

render.html index.css and <style> </style>
so I can test my own theme.

@Vanessa219 Vanessa219 self-assigned this Jul 1, 2020
@Vanessa219 Vanessa219 added this to the 3.3 milestone Jul 1, 2020
@Vanessa219 Vanessa219 changed the title [Question] Duplicate CSS(render.html) Duplicate CSS(render.html) Jul 1, 2020
Vanessa219 added a commit that referenced this issue Jul 1, 2020
@Vanessa219
🐛 fix #517
9f63cf5
@Vanessa219
Copy link
Owner

pls update this code
9f63cf5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vanessa219 Vanessa219

Labels
修复缺陷
Projects
None yet
Milestone
3.3
Development

No branches or pull requests
2 participants
@Vanessa219 @jakekwak