Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

中文输入过程中不应记录 UndoStack #532

Closed
zTree opened this issue Jul 2, 2020 · 4 comments
Closed

中文输入过程中不应记录 UndoStack #532

zTree opened this issue Jul 2, 2020 · 4 comments
Assignees
@Vanessa219
Labels
修复缺陷
Milestone
3.3

Comments

@zTree
Copy link
Contributor

zTree commented Jul 2, 2020

你在什么场景下需要该功能？

提个建议，你重构 Undo 部分的代码时，是否可以考虑一下 中文输入过程中不应记录 UndoStack ，否则在 undo 的时候，会看到正在输入的中文拼音；我刚提交了一个 pull request，测试感觉还有点儿问题，就取消了。

描述可能的解决方案

检测到正在输入中文时，不执行 addToUndoStack，只有最后中文输入结束时，才去执行。

Vditor 示例 - 黑客派
@Vanessa219 Vanessa219 linked a pull request Jul 2, 2020 that will close this issue
Fixed recordFirstWbr & setValue error #521
Closed
@Vanessa219
Copy link
Owner

收到，多谢

@Vanessa219 Vanessa219 self-assigned this Jul 2, 2020
@Vanessa219 Vanessa219 added this to the 3.3 milestone Jul 2, 2020
@Vanessa219
Copy link
Owner

这个 bug 是不是不太好重现呀？

@Vanessa219
Copy link
Owner

我也不知道修好没，因为我只重现了一次，凭感觉改了改。有空麻烦到分支上试试。

@zTree
Copy link
Contributor Author

zTree commented Jul 17, 2020

我也不知道修好没，因为我只重现了一次，凭感觉改了改。有空麻烦到分支上试试。

抱歉，这么久才看到，我大概测试了一下，用的是你最新的 master 上的代码，应该是没问题啦！辛苦辛苦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vanessa219 Vanessa219

Labels
修复缺陷
Projects
None yet
Milestone
3.3
Development

Successfully merging a pull request may close this issue.

Fixed recordFirstWbr & setValue error zTree/vditor
2 participants
@zTree @Vanessa219