Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

优化移动端体验 #71

Closed
jakekwak opened this issue Jan 13, 2020 · 37 comments
Closed

优化移动端体验 #71

jakekwak opened this issue Jan 13, 2020 · 37 comments
Assignees
Milestone

Comments

@jakekwak
Copy link
Contributor

Screenshot_20200112-184527_Chrome

And more toolbar option for testing.

@Vanessa219
Copy link
Owner

I tried some methods, but it didn't work out well. Do you have any good suggestions or demo?

@jakekwak
Copy link
Contributor Author

I mean the toolbar is not showing when i try to click the editor pane.

@Vanessa219
Copy link
Owner

I know, but I don't have a good solution. Can you give some suggestions?

@jakekwak
Copy link
Contributor Author

I want to test the vditor at the mobile. Is it mobile first? right?
When I click the editor pane at the demo, the toolbar pane have to be remained with more icon(same as desktop)

@88250 88250 changed the title using the editor at Smartphone, toolbar disapeared 优化移动端体验 Jan 21, 2020
@jakekwak
Copy link
Contributor Author

I want to test this editor using smartphone. please activate all toolbar.
2

@Vanessa219
Copy link
Owner

pls reload again

@jakekwak
Copy link
Contributor Author

I don't know which one is good for mobile.
but my idea is like picture..(WYSIWYG mode)
or special charater icon ( Markdown mode)
7

@88250 88250 mentioned this issue Jan 29, 2020
@jakekwak
Copy link
Contributor Author

jakekwak commented Apr 5, 2020

@88250 I think the next plan will be mobile browser. android phone, iphone, android tablet, iPad etc.
What do you think about your next plan?

@88250
Copy link
Collaborator

88250 commented Apr 5, 2020

@jakekwak Yes, you are right, it's time to keep moving on mobile-end. We can discuss it with @Vanessa219, decide the first thing we should do.

@88250 88250 pinned this issue Apr 5, 2020
@88250 88250 added this to the 3.1.0 milestone Apr 5, 2020
@stevapple
Copy link
Contributor

I personally suggest the toolbar to keep floating on the top when it’s in a mobile(narrow) browser. When it comes to tablet side, the exisiting desktop experience may win. It works well with iPadOS.

@jakekwak
Copy link
Contributor Author

jakekwak commented Apr 6, 2020

@stevapple I'm testing various browser at mobile environment.
I think trix is good ui. https://trix-editor.org/

@stevapple
Copy link
Contributor

stevapple commented Apr 6, 2020

@jakekwak I think trix is no better than vditor at the moment. Tested on iOS, the former has a problem of UI dislocation while the latter works pretty well.

vditor can consider to pin its bar onto the top of the screen and increase button sizes by a little bit. That’s the point.

@Vanessa219
Copy link
Owner

@stevapple @jakekwak do you like pin toolbar or floating bar?
image

@jakekwak
Copy link
Contributor Author

jakekwak commented Apr 6, 2020

How about the trix style. sticky toolbar style.

@Vanessa219
Copy link
Owner

@jakekwak pin toolbar is trix style

@jakekwak
Copy link
Contributor Author

jakekwak commented Apr 6, 2020

@Vanessa219 I tested the popular html editor. (froala, ckeditor4, Redactor, trix, summernote, tiptap etc.)
I think pin toolbar style is easier than others

@stevapple
Copy link
Contributor

The improvements of top bar may introduce a new mode in which the height of the editor is set to be the full length of content (dynamically) and virtual scrolling (scrolling inside the editor instead of window) is disabled. When the user scrolls over the content, top bar is sticked to (pinned at) the top of the window. (Like the trix one, I’ve got the point)

When it comes to the floating bar (currently), I think the biggest problem now is the size...Too small for smartphones (fairly speaking, not even big enough for desktop), thus hard to touch.

I think the size issue is more urgent, as full-screen mode is a fine substitute except for button sizes.

@88250
Copy link
Collaborator

88250 commented Apr 6, 2020

So, is the "pin bar" the best design on the mobile-end? Can I consider that we have reached an agreement? 😃

@stevapple
Copy link
Contributor

stevapple commented Apr 6, 2020

I think so. Just pin it on the top of the window If it should be above. 😄

@jakekwak
Copy link
Contributor Author

jakekwak commented Apr 6, 2020

@88250 Me, yes.
What is the best tesing env for smartphone? When I use the ngrok, the error msg is "invalid Host Header",
Can I disable this error temporarily? or any other good testing env.

@stevapple
Copy link
Contributor

stevapple commented Apr 6, 2020

@jakekwak What do you mean by “testing env”? Running the dev server on a PC and trying it out on a phone within the same LAN is easy and stable enough.

@jakekwak
Copy link
Contributor Author

jakekwak commented Apr 6, 2020

If possible, could you make experimental branch for IR mode.
Can type special symbols that are difficult to type on the keyboard.
Screenshot_20200331-110556

@88250
Copy link
Collaborator

88250 commented Apr 6, 2020

@jakekwak I agree with @stevapple: use the same WiFi with phone and PC should work.

@jakekwak
Copy link
Contributor Author

jakekwak commented Apr 6, 2020

@stevapple @88250 thanks.

@Vanessa219
Copy link
Owner

If possible, could you make experimental branch for IR mode.
Can type special symbols that are difficult to type on the keyboard.
Screenshot_20200331-110556

you can set the toolbar yourself.

toolbar: [
    {
      name: "point",
      prefix: ".",
      icon: ".",
      tip: 'point',
      tipPosition: 'ne',
      click: () => {
        vditor.insertValue('.', false)
      },
    }
  ],

@jakekwak
Copy link
Contributor Author

jakekwak commented Apr 7, 2020

@Vanessa219 Thanks, Can I put custom svg icon instead of text icon(icon: ".".)?

@Vanessa219
Copy link
Owner

Vanessa219 commented Apr 7, 2020

@lhlyu
Copy link

lhlyu commented Apr 8, 2020

like:
IMG_20200408_095016

@stevapple
Copy link
Contributor

stevapple commented Apr 8, 2020

@lhlyu Since vditor is a web-based editor, it cannot copy the approach of designing a native editor app which provides heavy functions nested in the same button. Also, it should consider the experience consistency between desktop and mobile-end.

However, a bottom bar may be introduced in the full-screen mode to provide text inserts (as long as there are APIs to pin the bar above the soft keyboard), like the one @jakekwak suggests.

@Vanessa219
Copy link
Owner

Maybe there is no API, so the pin top may be better than compatible with the bottom calculation?

@stevapple
Copy link
Contributor

stevapple commented Apr 8, 2020

It’s necessary to pin the top bar. Meanwhile, @jakekwak is adding some text insertion buttons on it, which may make it a little bit messy. @jakekwak, can the existing buttons like heading and bold satisfy your need? They work well on iOS.

@jakekwak
Copy link
Contributor Author

jakekwak commented Apr 8, 2020

@stevapple Always I don't know which method is good.
but if make some experimental branch for testing at every device.
Everybody can test which one is good.
My first idea is that user can select normal toolbar for wysiwyg mode or text toolbar for ir mode.
I try to test custom toolbar option (combined toolbar).
if I may not find it, but I am trying to find an easier way than current input method.

@jakekwak
Copy link
Contributor Author

jakekwak commented Apr 8, 2020

Here is some demo at android phone(chrome).

  1. sticky toolbar and touch friendly button.
  2. custom toolbar for indent, outdent like trix
  3. When touched the bottom after code, can not input
    20200407_223150

@Vanessa219
Copy link
Owner

@jakekwak how does trix customize indent and outdent?

Vanessa219 added a commit that referenced this issue Apr 8, 2020
Vanessa219 added a commit that referenced this issue Apr 8, 2020
@Vanessa219 Vanessa219 unpinned this issue Apr 8, 2020
stevapple pushed a commit to stevapple/vditor that referenced this issue Apr 8, 2020
stevapple pushed a commit to stevapple/vditor that referenced this issue Apr 8, 2020
stevapple pushed a commit to stevapple/vditor that referenced this issue Apr 8, 2020
Vanessa219 added a commit that referenced this issue Apr 8, 2020
@jakekwak
Copy link
Contributor Author

jakekwak commented Apr 8, 2020

@Vanessa219 I mean the user can do to put the indent in the toolbar.

@Vanessa219
Copy link
Owner

@jakekwak you mean this issue #286

@jakekwak
Copy link
Contributor Author

jakekwak commented Apr 9, 2020

@Vanessa219 Yes, Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants