Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 全屏模式文末空白 #292

Closed
wants to merge 1 commit into from
Closed

🐛 全屏模式文末空白 #292

wants to merge 1 commit into from

Conversation

stevapple
Copy link
Contributor

@stevapple stevapple commented Apr 9, 2020 •
edited

修复全屏模式下文末无故空白（由 :after 引起）。

@stevapple stevapple changed the base branch from master to dev April 9, 2020 03:20
@Vanessa219
Copy link
Owner

Vanessa219 commented Apr 9, 2020 •
edited

是什么样子的么？可以把参数和截图发我看看不？

@stevapple
Copy link
Contributor Author

@Vanessa219 用 master 跑一下，height > viewport 高度时全屏模式最后就会有一大段空白。

@stevapple
Copy link
Contributor Author

定位到是因为 :after 元素有高度导致的。

@stevapple
Copy link
Contributor Author

对了，我不是很清楚注释里说的 FireFox 那个问题是什么，所以还是保留了 :after 在非全屏模式下的行为；修复后的全屏模式已经在 WebKit（Safari）、Chromium（Opera）和 Gecko（FireFox）上验证过可靠性。

@Vanessa219
Copy link
Owner

那个是为 typewriterMode 服务的

@stevapple
Copy link
Contributor Author

这个 mode 的设计目的是？我在体验的时候没发现和以前有哪些不同。

@Vanessa219 Vanessa219 added this to the 3.1.0 milestone Apr 9, 2020
@Vanessa219 Vanessa219 self-assigned this Apr 9, 2020
@stevapple
Copy link
Contributor Author

好像懂了，那我的修改有点小问题
等我再改一下

@Vanessa219
Copy link
Owner

Vanessa219 commented Apr 9, 2020 •
edited

b3log/vditor#90

image

@Vanessa219
Copy link
Owner

呃。我已经修复了。麻烦你了。

@Vanessa219 Vanessa219 closed this Apr 9, 2020
Vanessa219 added a commit that referenced this pull request Apr 9, 2020
@Vanessa219
🐛 fix #292
6a72510
@stevapple
Copy link
Contributor Author

额，好像我说的不是你修的那个来着……我新开了一个 PR 你看看 #294

@Vanessa219
Copy link
Owner

收到

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Vanessa219 Vanessa219

Labels
修复缺陷
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stevapple @Vanessa219