Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ 允许开启 counter 而不设置限值 & README 优化 #298

Merged
merged 2 commits into from Apr 10, 2020
Merged

✨ 允许开启 counter 而不设置限值 & README 优化 #298

merged 2 commits into from Apr 10, 2020

Conversation

stevapple
Copy link
Contributor

@stevapple stevapple commented Apr 10, 2020 •
edited

允许通过设置 options.counter: true 来启用字数统计。

为 Counter.render 添加了第三个参数，以支持对于字数统计功能的后续改进，例如 #297 。对现有 API 无影响。

P.S. 建议使用 Markdown: 12/100 风格的字符统计标签，更为正式的同时也符合其他主流本地编辑器的做法。本 PR 不包括这一改动。

其他变化：其他组件应该使用 vditor.options.counter != false 而非 vditor.options.counter > 0 来判断字数统计的开启情况。

  • 补充了 README 内容
  • 统一了 README 风格

@stevapple stevapple mentioned this pull request Apr 10, 2020
Closed
@stevapple stevapple force-pushed the counter branch 5 times, most recently from cab3eac to d6be563 Compare April 10, 2020 04:46
@stevapple stevapple changed the title ✨ 允许开启 counter 而不设置限值 ✨ 允许开启 counter 而不设置限值 & README 优化 Apr 10, 2020
@Vanessa219 Vanessa219 added this to the 3.1.0 milestone Apr 10, 2020
@Vanessa219 Vanessa219 merged commit 24e85c3 into Vanessa219:dev Apr 10, 2020
Vanessa219 added a commit that referenced this pull request Apr 10, 2020
@Vanessa219
📝 #298
9148b31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@stevapple stevapple

Labels
引入特性
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stevapple @Vanessa219