Skip to content

Deprecate logging API #2774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tsegismont opened this issue Dec 21, 2018 · 3 comments
Closed

Deprecate logging API #2774

tsegismont opened this issue Dec 21, 2018 · 3 comments
Assignees
@tsegismont
Labels
to review
Milestone
4.0.0

Comments

@tsegismont
Copy link
Contributor

tsegismont commented Dec 21, 2018 •
edited by vietj
Loading

The Vert.x logging API is public and advertised in the docs. Besides, there are a couple of issues as it supports parameterised logging methods without standardising on a message format (it delegates this to the logging backend so messages are not portable).

Therefore, we regularly get questions/bug reports about this, which increases the maintenance effort. Also, it's not good to provide a non-working feature only to cause users' disappointment.

Considering it's not a programming toolkit responsibility to provide yet another logging API, the Vert.x loggers shall be deprecated and, in a later major version made internal.
@tsegismont tsegismont added this to the 4.0.0 milestone Dec 21, 2018
@tsegismont tsegismont self-assigned this Dec 21, 2018
tsegismont added a commit to tsegismont/vert.x that referenced this issue Dec 21, 2018
@tsegismont
Deprecate logging API
0d9e17f 
Fixes eclipse-vertx#2774

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
@tsegismont tsegismont mentioned this issue Dec 21, 2018
Merged
@tsegismont tsegismont mentioned this issue Dec 21, 2018
Closed
tsegismont added a commit to tsegismont/vert.x that referenced this issue Jan 2, 2019
@tsegismont
Deprecate logging API
b9a3925 
Fixes eclipse-vertx#2774

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont added a commit to tsegismont/vert.x that referenced this issue Jan 8, 2019
@tsegismont
Deprecate logging API
36eaae0 
Fixes eclipse-vertx#2774

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont added a commit to tsegismont/vert.x that referenced this issue Jan 8, 2019
@tsegismont
Deprecate logging API
45b11e7 
Fixes eclipse-vertx#2774

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont added a commit that referenced this issue Jan 8, 2019
@tsegismont
Deprecate logging API (#2775)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
f650f1f 
Fixes #2774

Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
@uicodefr uicodefr mentioned this issue Mar 17, 2019
Closed
@pjeziorowski pjeziorowski mentioned this issue Mar 7, 2020
Open
@michael72 michael72 mentioned this issue Sep 13, 2023
Merged
@yaduvesh
Copy link

yaduvesh commented Jan 4, 2024

After this change the class Log4j2LogDelegateFactory is deprecated, however the documentation still mentions the system property to redirect vertx internally logging to specific backend like log4j2.
What is the recommendation on using the system property given in docs now on?

@tsegismont
Copy link
Contributor Author

The Log4j2LogDelegateFactory class is not deprecated: https://github.com/eclipse-vertx/vert.x/blob/master/src/main/java/io/vertx/core/logging/Log4j2LogDelegateFactory.java

The documentation is valid.

@yaduvesh
Copy link

yaduvesh commented Jan 5, 2024

The Log4j2LogDelegateFactory class is not deprecated: https://github.com/eclipse-vertx/vert.x/blob/master/src/main/java/io/vertx/core/logging/Log4j2LogDelegateFactory.java

The documentation is valid.

Thanks for confirming.
My bad, I meant io.vertx.core.logging.LoggerFactory is deprecated which has the java constant for system property 'vertx.logger-delegate-factory-class-name'. Hence wanted to clarify if this system property was still valid.

I do see that in the master branch the above LoggerFactory class is removed now and the java constant is moved to the internal impl LoggerFactory class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsegismont tsegismont

Labels
to review
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
3 participants
@pmlopes @tsegismont @yaduvesh