feat: warn when remote is used without enableRemoteModule: true #21546
Conversation
|
Looks solid to me, but I wonder if we should add a link. That can happen in a later PR though, I'd first have to write said document. |
|
@felixrieseberg where should we link to? |
| @@ -321,7 +321,7 @@ const unwrapArgs = function (sender: electron.WebContents, frameId: number, cont | |||
|
|
|||
| const isRemoteModuleEnabledImpl = function (contents: electron.WebContents) { | |||
| const webPreferences = (contents as any).getLastWebPreferences() || {} | |||
| return !!webPreferences.enableRemoteModule | |||
| return webPreferences.enableRemoteModule != null ? !!webPreferences.enableRemoteModule : true | |||
There was a problem hiding this comment.
I think the reason why the default was false is that devtools webContents don’t have webPreferences and the remote module should be disabled there
There was a problem hiding this comment.
Hm, do you have suggestions for how we can detect devtools webcontents but also know whether remote module was explicitly enabled?
There was a problem hiding this comment.
I can do this in a follow-up PR if I don’t forget
|
Release Notes Persisted
|
Description of Change
This is the first step of #21408, issuing a warning when using the 'remote' module without
enableRemoteModule: true.Checklist
npm testpassesRelease Notes
Notes: Began issuing a deprecation warning when the 'remote' module is used when enableRemoteModule: true isn't explicitly specified. See #21408 for more details.