Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add API for receiving logs from service workers #22313

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Feb 20, 2020

Backport of #20624

See that PR for details.

Notes: Added session.serviceWorkerContext API to access basic service worker info and receive console logs from service workers.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 20, 2020
@trop trop bot requested a review from MarshallOfSound February 20, 2020 23:19
@trop trop bot added 9-x-y backport This is a backport PR labels Feb 20, 2020
@jkleinsc jkleinsc changed the title feat: add API for receiving logs from service workers [WIP] (until vote) feat: add API for receiving logs from service workers Feb 21, 2020
@jkleinsc
Copy link
Contributor

Marking as WIP until releases WG can vote on this one.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 21, 2020
@sofianguy
Copy link
Contributor

Approved by Releases WG on 2/26/2020

@jkleinsc jkleinsc changed the title [WIP] (until vote) feat: add API for receiving logs from service workers feat: add API for receiving logs from service workers Feb 27, 2020
@jkleinsc
Copy link
Contributor

Merging as CI failure unrelated to PR change.

@jkleinsc jkleinsc merged commit 0d7e13d into 9-x-y Feb 27, 2020
@release-clerk
Copy link

release-clerk bot commented Feb 27, 2020

Release Notes Persisted

Added session.serviceWorkerContext API to access basic service worker info and receive console logs from service workers.

@jkleinsc jkleinsc deleted the trop/9-x-y-bp-feat-add-api-for-receiving-logs-from-service-workers-1582240759399 branch February 27, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants