feat: set app.enableRendererProcessReuse to true by default #22336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are two spec fixes in this PR as well:
|
nornagon
approved these changes
Feb 22, 2020
MarshallOfSound
force-pushed
the
enable-renderer-process-reuse
branch
from
0da3067
to
dd6063b
Compare
zcbenz
approved these changes
Feb 25, 2020
|
Release Notes Persisted
|
|
I was unable to backport this PR to "9-x-y" cleanly; |
MarshallOfSound
added a commit
that referenced
this pull request
Feb 26, 2020
* feat: set app.enableRendererProcessReuse to true by default * chore: add context aware info to breaking changes doc * spec: fix nodeIntegration in child windows test for rendererprocessreuse * spec: fix remote listeners in destroyed renderers spec as the error is now async * Update api-browser-window-spec.ts * chore: deprecate affinity * chore: fix docs * spec: handle tests crashing without an exist code * spec: update tests for new rendererprocessreuse default * spec: with renderer process re-use we get to destroy less views
|
@MarshallOfSound has manually backported this PR to "9-x-y", please check out #22401 |
MarshallOfSound
added a commit
that referenced
this pull request
Feb 27, 2020
…22401) * feat: set app.enableRendererProcessReuse to true by default * chore: add context aware info to breaking changes doc * spec: fix nodeIntegration in child windows test for rendererprocessreuse * spec: fix remote listeners in destroyed renderers spec as the error is now async * Update api-browser-window-spec.ts * chore: deprecate affinity * chore: fix docs * spec: handle tests crashing without an exist code * spec: update tests for new rendererprocessreuse default * spec: with renderer process re-use we get to destroy less views
nornagon
added a commit
to electron/remote
that referenced
this pull request
Jun 17, 2020
nornagon
added a commit
to electron/remote
that referenced
this pull request
Jun 17, 2020
nornagon
added a commit
to electron/remote
that referenced
this pull request
Jun 17, 2020
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the timeline in #18397 we should flip this for Electron 9.
BREAKING CHANGE
Notes: Changed the default value of
app.allowRendererProcessReusetotrue, this will prevent loading of non-context-aware native modules in renderer processes. See #18397 for more information on this change.