-
Notifications
You must be signed in to change notification settings - Fork 16k
feat: set app.enableRendererProcessReuse to true by default #22336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There are two spec fixes in this PR as well:
|
0da3067
to
dd6063b
Compare
Release Notes Persisted
|
I was unable to backport this PR to "9-x-y" cleanly; |
* feat: set app.enableRendererProcessReuse to true by default * chore: add context aware info to breaking changes doc * spec: fix nodeIntegration in child windows test for rendererprocessreuse * spec: fix remote listeners in destroyed renderers spec as the error is now async * Update api-browser-window-spec.ts * chore: deprecate affinity * chore: fix docs * spec: handle tests crashing without an exist code * spec: update tests for new rendererprocessreuse default * spec: with renderer process re-use we get to destroy less views
@MarshallOfSound has manually backported this PR to "9-x-y", please check out #22401 |
…22401) * feat: set app.enableRendererProcessReuse to true by default * chore: add context aware info to breaking changes doc * spec: fix nodeIntegration in child windows test for rendererprocessreuse * spec: fix remote listeners in destroyed renderers spec as the error is now async * Update api-browser-window-spec.ts * chore: deprecate affinity * chore: fix docs * spec: handle tests crashing without an exist code * spec: update tests for new rendererprocessreuse default * spec: with renderer process re-use we get to destroy less views
As per the timeline in #18397 we should flip this for Electron 9.
BREAKING CHANGE
Notes: Changed the default value of
app.allowRendererProcessReuse
totrue
, this will prevent loading of non-context-aware native modules in renderer processes. See #18397 for more information on this change.