Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add session.removeWordFromSpellCheckerDictionary API #22368

Merged
merged 2 commits into from
Mar 2, 2020
Merged

feat: add session.removeWordFromSpellCheckerDictionary API #22368

merged 2 commits into from
Mar 2, 2020

Conversation

erickzhao
Copy link
Member

Backport of #22039

See that PR for details.

Notes: Added session.removeWordFromSpellCheckerDictionary API to remove custom words in the dictionary.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 25, 2020
@trop trop bot mentioned this pull request Feb 25, 2020
Merged
6 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels Feb 25, 2020
@erickzhao erickzhao requested a review from a team February 25, 2020 01:32
@erickzhao
Copy link
Member Author

Continuation of #22127, but now off of my fork because I needed write access to rebase.

@t3chguy t3chguy mentioned this pull request Feb 25, 2020
Merged
@erickzhao erickzhao removed the request for review from a team February 25, 2020 23:24
@erickzhao
Copy link
Member Author

Pending #22198 roll

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 26, 2020
@jkleinsc
Copy link
Member

This was approved for 9-x-y via #22127 (comment)

@erickzhao erickzhao force-pushed the trop/9-x-y-bp-feat-add-session-removewordfromspellcheckerdictionary-api-1581372456735 branch from 7e2bacf to 649a6a8 Compare March 2, 2020 21:58
@MarshallOfSound MarshallOfSound merged commit 3d65d84 into electron:9-x-y Mar 2, 2020
@release-clerk
Copy link

release-clerk bot commented Mar 2, 2020

Release Notes Persisted

Added session.removeWordFromSpellCheckerDictionary API to remove custom words in the dictionary.

@erickzhao erickzhao deleted the trop/9-x-y-bp-feat-add-session-removewordfromspellcheckerdictionary-api-1581372456735 branch March 2, 2020 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound

Assignees
No one assigned
Labels
9-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erickzhao @jkleinsc @MarshallOfSound