Looks like a great PR. @bparrishMines Could you help to review this PR & merge? :-)

Note for reviewer: #860 seems to be doing the same.

this functionality is very useful, nice job.

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

video_player from @JONA-Cureambit is awesome!
It works well.

pubspec.yaml

@luckypal , whick video server are you using? I'm trying with Vimeo, but receives that when I call setSpeed:
codec does not support config operating rate (err -1010)

playerItem.canPlayFastForward is always false in current implement for a .m3u8 video

Has anyone gotten this to work with web yet? Using

  video_player:
    git:
      url: https://github.com/JONA-Cureambit/plugins.git
      path: packages/video_player

May be related to flutter/flutter#42880 @JONA-Cureambit @recastrodiaz

Please, implement that! It's very important...

I have waitting for one year for this, when will it be ready;

+1

Can someone clarify which author consent currently can't be verified (and thus is blocking the PR)?

This PR will break web support and should not be merged until that is corrected. Web is now supported by the official video player.

@MichealReed : As far as I understand the general guidelines, then it's not required to support a feature on all platforms to add it: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#avoid-the-lowest-common-denominator

I hope we can make it work in android and ios;

@bparrishMines @iskakaushik can you please review this PR. It is waiting in Queue since 1 year.
Many will be benefited with this feature.

@MichealReed : As far as I understand the general guidelines, then it's not required to support a feature on all platforms to add it: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#avoid-the-lowest-common-denominator

This section of the documentation is talking about providing proper support based on what supported platforms have available, not excusing a lack of support for a specific platform. It is perfectly viable to support this on web with full features. The video player plugin supports web today, and that support should not be broken because of this feature.

In general video player support for web wouldn't be broken. Everything that possible today with the web client would also be possible if this pull request would be merged.

If there's a general policy of "Pull request for new features should only be merged once the new feature is available for all supported platforms" such a policy should be explicit in the style guide (or another document such as the contributor guide).

While such a policy has some advantages it produces problem such as lower code quality (developers get forced to write code outside of their core languages to contribute a new feature) and it slows down the adoption of new features espcially as the number of supported platforms grows in the future.

flutter for ios and android has been released for 1.5 years, but flutter for web still in beta yet; so it is reasonable for plugins to support ios and android first and then support for web in another step;

Hope that you got this solved ASAP. Today almost everyone that consume information videos daily like and use that feature. The lack of it it's really annoying. And know that it's waiting for 1 year to be accepted it's unbelievable.

Is there a reason why the feature isn't implemented for web? It seems as though these methods just have to be implemented in the video_player_web.dart file

In general video player support for web wouldn't be broken. Everything that possible today with the web client would also be possible if this pull request would be merged.

If there's a general policy of "Pull request for new features should only be merged once the new feature is available for all supported platforms" such a policy should be explicit in the style guide (or another document such as the contributor guide).

While such a policy has some advantages it produces problem such as lower code quality (developers get forced to write code outside of their core languages to contribute a new feature) and it slows down the adoption of new features espcially as the number of supported platforms grows in the future.

I manually merged this PR with a fork of master that works on web and can confirm that the video player on web entirely breaks from this PR. I understand that the new features might not need to function immediately on web, but it should at least retain functionality.

Inspired by the project, I reimplemented the project in a basic new version and applied it to my current APP.But I'm sorry I'm not familiar with IOS development so it only supports Android.
video_player
Thanks to the author

Any update here?

Anything?

@JONA-Cureambit 👇 It's mentioned that your consent is not verified.

Just a note to anyone waiting for an update to this: I implemented the playback speed feature for the latest version of video_player and have a finished PR: #3031

However, I am still awaiting review and we can hopefully get the three parts merged soon 🙂

Published video_player v0.11.0, which contains the playback speed feature!