Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vanessa.js.org #1025

Merged
merged 1 commit into from Jan 27, 2017
Merged

vanessa.js.org #1025

merged 1 commit into from Jan 27, 2017

Conversation

Vanessa219
Copy link
Contributor

  • There is reasonable content on the page (see: No Content)
  • I have read and accepted the ToS

@indus indus changed the title add vanessa site vanessa.js.org Jan 24, 2017
@indus indus added add This PR/issue is regarding adding a new subdomain bug project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account labels Jan 24, 2017
@indus
Copy link
Member

indus commented Jan 24, 2017

Looks like you are not using a gh-pages branch. Have you set your master branch to act as GitHub Pages? FYI: https://help.github.com/articles/configuring-a-publishing-source-for-github-pages/

@Vanessa219
Copy link
Contributor Author

My master branch has acted as GitHub Pages. Thx.

@indus
Copy link
Member

indus commented Jan 25, 2017

But it looks like it is not configured correctly. You have to do the settings explicitly in the settings section of your repo, because it is a project repo and not a user repo (would have the name vanessa219.github.io)

@indus
Copy link
Member

indus commented Jan 25, 2017

Reading this again it looks like you have to put CNAME to /docs and not on the root level.

@Vanessa219
Copy link
Contributor Author

So sorry, when I use docs, It's not work. so, I removed it.

When I add docs to my master branch and select master branch /docs folder as my GitHub Pages publishing source. It's not work, but select master branch, it's ok. e.g: https://vanessa.js.org/

what ever, Thx so much!

@indus
Copy link
Member

indus commented Jan 27, 2017

Welcome https://vanessa.js.org

@indus indus removed the bug label Jan 27, 2017
@indus indus merged commit cfb8055 into js-org:master Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants