Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move dock plugin icon does not maintain its position #10237

Closed
3 tasks done
TCOTC opened this issue Jan 23, 2024 · 17 comments
Closed
3 tasks done

Move dock plugin icon does not maintain its position #10237

TCOTC opened this issue Jan 23, 2024 · 17 comments
Assignees
@Vanessa219
Labels
Development
Milestone
2.12.5

Comments

@TCOTC
Copy link
Contributor

TCOTC commented Jan 23, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Can the issue be reproduced with the default theme (daylight/midnight)?

  • I was able to reproduce the issue with the default theme

Could the issue be due to extensions?

  • I've ruled out the possibility that the extension is causing the problem.

Describe the problem

插件在Dock栏的位置无法保存，「移动到X侧X方」的操作无效，在下次打开思源笔记时会恢复默认的位置。

实际问题见：Zuoqiu-Yingyi/siyuan-plugin-monaco-editor#25

Expected result

保存插件在Dock栏的位置，并在打开软件时正确加载。

Screenshot or screen recording presentation

image

Version environment

- Version: v2.12.4
- Operating System: Windows 10
- Browser (if used):

Log file

system-log.zip

More information

No response
@Vanessa219 Vanessa219 self-assigned this Jan 24, 2024
@Vanessa219 Vanessa219 added this to the 2.12.5 milestone Jan 24, 2024
Vanessa219 added a commit that referenced this issue Jan 24, 2024
@Vanessa219
🐛 fix #10237
6930d48
@Vanessa219 Vanessa219 changed the title 插件在Dock栏/侧边面板的布局无法保存 Move dock plugin icon does not maintain its position Jan 24, 2024
@Vanessa219
Copy link
Member

这个应该是插件的问题，

@TCOTC TCOTC mentioned this issue Jan 24, 2024
Closed
@Zuoqiu-Yingyi
Copy link
Contributor

这个应该是插件的问题，

移动 插件示例 的侧边面板后正常退出, 再次打开也会重置位置

@TCOTC
Copy link
Contributor Author

TCOTC commented Jan 24, 2024 •
edited

不需要重启，只要重新加载界面就会出现这个问题

@88250 88250 mentioned this issue Jan 24, 2024
Closed
3 tasks
@Zuoqiu-Yingyi
Copy link
Contributor

@Vanessa219 目前插件添加的侧边栏加载的逻辑还有问题, 无论保存的界面布局如何, 相关的配置(侧边栏位置, 是否展开, 宽度等)在每次加载时都会被忽略, 导致实际上保存的侧边栏布局是无效的

@Vanessa219
Copy link
Member

抱歉，错屏了。中午已经提交代码了。
image

@Vanessa219
Copy link
Member

@Vanessa219 目前插件添加的侧边栏加载的逻辑还有问题, 无论保存的界面布局如何, 相关的配置(侧边栏位置, 是否展开, 宽度等)在每次加载时都会被忽略, 导致实际上保存的侧边栏布局是无效的

最新代码还有问题？

@Zuoqiu-Yingyi
Copy link
Contributor

最新代码还有问题？

目前看暂时没啥问题了

@winter60
Copy link

@Vanessa219
image
不知道是不是这个的问题。 开启后，经常重置布局。
image

@TCOTC
Copy link
Contributor Author

TCOTC commented Feb 11, 2024

image 不知道是不是这个的问题。 开启后，经常重置布局。 image

我没开，一直会重置

@Vanessa219
Copy link
Member

@TCOTC 什么情况下会重置？

@winter60 我这里是正常的，是因为安装了什么插件么？

@winter60
Copy link

@winter60 我这里是正常的，是因为安装了什么插件么？

文件资源管理器、代码编辑、收集箱这三个。

@TCOTC
Copy link
Contributor Author

TCOTC commented Feb 12, 2024

@TCOTC 什么情况下会重置？

哦，我说的是 2.12.4 版本的时候，现在新版暂时还没遇到会重置的情况

@Vanessa219
Copy link
Member

Vanessa219 commented Feb 12, 2024 •
edited

文件资源管理器、代码编辑、收集箱这三个。

移除了还会重置么？

@winter60
Copy link

移除了还会重置么？

不会了

@Vanessa219
Copy link
Member

@winter60 有具体的重现步骤么？

@winter60
Copy link

default.mp4

@Vanessa219

@Vanessa219
Copy link
Member

可以重现了，下个版本改进。多谢。

Vanessa219 added a commit that referenced this issue Feb 16, 2024
@Vanessa219
🎨 fix #10237
6f8c117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vanessa219 Vanessa219

Labels
Development
Projects
None yet
Milestone
2.12.5
Development

No branches or pull requests
4 participants
@Vanessa219 @winter60 @Zuoqiu-Yingyi @TCOTC