Skip to content

Improve web clip table parsing #10799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
TCOTC opened this issue Mar 30, 2024 · 1 comment
Closed
3 tasks done

Improve web clip table parsing #10799

TCOTC opened this issue Mar 30, 2024 · 1 comment
Assignees
@88250
Labels
Enhancement
Milestone
3.0.6

Comments

@TCOTC
Copy link
Contributor

TCOTC commented Mar 30, 2024 •
edited by 88250
Loading

改进浏览器剪藏扩展处理表头

Is there an existing issue for this?

  • I have searched the existing issues

Can the issue be reproduced with the default theme (daylight/midnight)?

  • I was able to reproduce the issue with the default theme

Could the issue be due to extensions?

  • I've ruled out the possibility that the extension is causing the problem.

Describe the problem

剪藏这个网址：https://cloud.tencent.com/developer/article/2362589

剪藏不了表头：

image

image

Version environment

- Version: 3.0.6-dev2
- Operating System: Win10
- Browser (if used):
@TCOTC TCOTC changed the title 改进剪藏 改进浏览器剪藏扩展处理表头 Mar 30, 2024
@88250
Copy link
Member

88250 commented Mar 31, 2024 •
edited
Loading

简单看了下，应该是因为 https://github.com/siyuan-note/siyuan-chrome/blob/main/lib/Readability.js 中提取表格内容的时候把 table 表头单元格内容剔除了，这个定位起来有点麻烦，暂时先记录下。

@88250 88250 self-assigned this Apr 1, 2024
@88250 88250 added this to the 3.0.6 milestone Apr 1, 2024
@88250 88250 changed the title 改进浏览器剪藏扩展处理表头 Improve web clip table parsing Apr 1, 2024
88250 added a commit to siyuan-note/siyuan-chrome that referenced this issue Apr 1, 2024
@88250
🎨 Improve web clip table parsing siyuan-note/siyuan#10799

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
643709a
@88250 88250 closed this as completed Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@88250 88250

Labels
Enhancement
Projects
None yet
Milestone
3.0.6
Development

No branches or pull requests
2 participants
@88250 @TCOTC