Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Database table view select column does not set default selection #10829

Closed
3 tasks done
woniuxia opened this issue Apr 2, 2024 · 25 comments
Closed
3 tasks done

Database table view select column does not set default selection #10829

woniuxia opened this issue Apr 2, 2024 · 25 comments
Assignees
@Vanessa219
Labels
Enhancement
Milestone
3.0.9

Comments

@woniuxia
Copy link

woniuxia commented Apr 2, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Can the issue be reproduced with the default theme (daylight/midnight)?

  • I was able to reproduce the issue with the default theme

Could the issue be due to extensions?

  • I've ruled out the possibility that the extension is causing the problem.

Describe the problem

当前单选/多选选项第一个选项的背景色是加深的，类似鼠标悬浮的效果，感觉好像不对劲。
明明是选中了其他的选项，当前这个感觉就像选中了第一个选项
image

Expected result

第一个选项展示正常

Screenshot or screen recording presentation

No response

Version environment

- Version:  v3.0.6
- Operating System: 
- Browser (if used):

Log file

无

More information

No response
@TCOTC TCOTC mentioned this issue Apr 2, 2024
Closed
@TCOTC
Copy link
Contributor

TCOTC commented Apr 2, 2024 •
edited

应该是 #10738 造成的，目前是始终着重显示首个选项

@woniuxia
Copy link
Author

woniuxia commented Apr 2, 2024

应该是 #10738 造成的，目前是始终着重显示首个选项

自己提的 feature，自己来提 bug，哈哈哈哈

@TCOTC
Copy link
Contributor

TCOTC commented Apr 2, 2024

自己提的 feature，自己来提 bug，哈哈哈哈

我也提了一堆，都要自己跟进才行

@Vanessa219
Copy link
Member

背景高亮指的的是当前选中项，可以使用快捷键上下、回车进行操作的项。后面有勾选的才是单元格中已有的项。

@TCOTC
Copy link
Contributor

TCOTC commented Apr 3, 2024 •
edited

但现在的问题不是这个嘛：

当前单选/多选选项第一个选项的背景色是加深的，明明是选中了其他的选项，当前这个感觉就像选中了第一个选项

@woniuxia
Copy link
Author

woniuxia commented Apr 3, 2024

@Vanessa219 V大，现在第一个选项不论是否被选中都是背景加深的，不符合预期

@Vanessa219
Copy link
Member

Vanessa219 commented Apr 3, 2024 •
edited

背景高亮指的的是当前选中项，可以使用快捷键上下、回车进行操作的项。后面有勾选的才是单元格中已有的项。

你按一下下键，背景高亮就会切换到下一个了。背景高亮和斜杆菜单是一样的，表示当前要操作的项。

image

@TCOTC
Copy link
Contributor

TCOTC commented Apr 3, 2024 •
edited

确实。

不过这个勾是不是放到前面更好？离得太远了看不见也没什么意义

image

@TCOTC
Copy link
Contributor

TCOTC commented Apr 3, 2024

@Vanessa219 另外这个地方有点不对：

image

@Vanessa219
Copy link
Member

这样？
image

@Vanessa219 Vanessa219 mentioned this issue Apr 3, 2024
Open
@TCOTC
Copy link
Contributor

TCOTC commented Apr 3, 2024

感觉还是奇怪并且不好看，要不别用勾了，想想其他的形式

@TCOTC
Copy link
Contributor

TCOTC commented Apr 3, 2024

比如说选中的就在前面加一个色块：

image

@Vanessa219
Copy link
Member

呃，要不先不动吧

image

@TCOTC
Copy link
Contributor

TCOTC commented Apr 3, 2024 •
edited

这个样式感觉挺好。

原来的样式会导致编辑按钮参差不齐，就很烦：

image

把勾改到前面去的话，也会因为选项文本长度不同而参差不齐

image

@Vanessa219
Copy link
Member

不好看呀，而且表现不出是已选中的数据

@TCOTC
Copy link
Contributor

TCOTC commented Apr 4, 2024

不好看呀

可以再看看怎么改

表现不出是已选中的数据

用户用几次就知道是怎么回事了

@Vanessa219
Copy link
Member

看了下其他家的好像没有这种 😄

@TCOTC
Copy link
Contributor

TCOTC commented Apr 4, 2024 •
edited

我也专门看过，其他家都不管这个。所以思源做了就更方便

@woniuxia
Copy link
Author

woniuxia commented Apr 6, 2024 •
edited

背景高亮指的的是当前选中项，可以使用快捷键上下、回车进行操作的项。后面有勾选的才是单元格中已有的项。

你按一下下键，背景高亮就会切换到下一个了。背景高亮和斜杆菜单是一样的，表示当前要操作的项。

image

V大，我试了下，懂第一个选项加深的含义了。
不过感觉相对于斜杠菜单，希望能优化一下，如果鼠标介入选择的时候，取消第一个选项的背景加深，转为只对鼠标指向的选项加深，这样就没有歧义了。
如下图不但很怪，还容易引起误会。
image

@TCOTC
Copy link
Contributor

TCOTC commented Apr 6, 2024

@Vanessa219 其他地方是要先按一次 ↑/↓ 才会出现背景高亮的：

选择

@Vanessa219
Copy link
Member

好像很有道理

@Vanessa219 Vanessa219 reopened this Apr 9, 2024
@Vanessa219 Vanessa219 added this to the 3.0.9 milestone Apr 9, 2024
@Vanessa219 Vanessa219 changed the title 数据库单选/多选列选项展示优化 Database table view select column does not set default selection Apr 9, 2024
Vanessa219 added a commit that referenced this issue Apr 10, 2024
@Vanessa219
🎨 fix #10829
d08ffd8
@TCOTC
Copy link
Contributor

TCOTC commented Apr 12, 2024

@Vanessa219 我又想到了，没有选则的话是灰色，选则的就变亮：

image

@Vanessa219
Copy link
Member

变亮和上下键选中和鼠标移动样式会有冲突

@TCOTC
Copy link
Contributor

TCOTC commented Apr 26, 2024

变亮和上下键选中和鼠标移动样式会有冲突

@Vanessa219 只是在前面加一个明显的色块，应该不会跟灰色背景冲突吧？

p.s. 是方形圆角的色块，而不是像闪卡高亮那样的

@Vanessa219
Copy link
Member

先不动了，一般选中都是整个背景高亮。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vanessa219 Vanessa219

Labels
Enhancement
Projects
None yet
Milestone
3.0.9
Development

No branches or pull requests
3 participants
@Vanessa219 @woniuxia @TCOTC