Skip to content

Undo exception after folding heading is cut #11312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
allrobot opened this issue May 8, 2024 · 5 comments
Closed
3 tasks done

Undo exception after folding heading is cut #11312

allrobot opened this issue May 8, 2024 · 5 comments
Assignees
@88250 @Vanessa219
Labels
Bug
Milestone
3.0.14

Comments

@allrobot
Copy link

allrobot commented May 8, 2024 •
edited by 88250
Loading

全选时，未能勾选折叠的内容，撤销操作报告状态异常需重建索引

Is there an existing issue for this?

  • I have searched the existing issues

Can the issue be reproduced with the default theme (daylight/midnight)?

  • I was able to reproduce the issue with the default theme

Could the issue be due to extensions?

  • I've ruled out the possibility that the extension is causing the problem.

Describe the problem

全选剪切未能勾选折叠的内容

SiYuan_Iad2U6I6lr

撤销操作时报告状态异常

SiYuan_SJrQADD449

其它
发生了偶然事件，写地好好的，突然siyuan界面变成加载状态，中间的图标小一点，大概2~4秒左右，加载完了之前写好的内容消失了，左边点文件历史还原找不到截图中参考代码如下和deadline增加时间上限中间的python代码了，history文件夹里面也找不到代码

吐槽，这太突然了，写作都要录屏防止偶然事件吗

Expected result

  1. 写作途中阻止软件突然加载，导致内容离奇消失……
  2. 正常剪切粘贴，不要漏折叠的内容

Screenshot or screen recording presentation

No response

Version environment

- Version: latest
- Operating System: WIN10 企业 21H2
- Browser (if used):No

Log file

siyuan.log

More information

No response
@88250
Copy link
Member

88250 commented May 8, 2024

  1. 标题块折叠后剪切不会带有其下方块一并剪切，而是自动展开下方块
  2. 请不要使用代码片段和插件等扩展后完整录屏操作步骤，包括编辑和撤销的顺序

@allrobot
Copy link
Author

allrobot commented May 8, 2024 •
edited
Loading

  1. 标题块折叠后剪切不会带有其下方块一并剪切，而是自动展开下方块
  2. 请不要使用代码片段和插件等扩展后完整录屏操作步骤，包括编辑和撤销的顺序

  1. 明白这是siyuan的使用策略了

  2. 代码片段为什么不能用，9成笔记都要用到代码片段的，代码片段有什么因素会导致BUG出现？

完整截图：

SiYuan_lZNyI1clVg

状态异常可能是全文剪切后，折叠的自动展开，撤销操作就要把展开的折叠起来导致的？

其它：
如果插件生成了文本，siyuan似乎没法把插件生成的文本撤销掉，无法进行完整的撤销操作：

SiYuan_tPQqMDZIok

@88250
Copy link
Member

88250 commented May 9, 2024

代码片段为什么不能用，9成笔记都要用到代码片段的，代码片段有什么因素会导致BUG出现？

我指的是思源中的扩展功能（设置 - 外观 - 代码片段），插件/代码片段可能会影响正常运行。后面插件生成的文本无法撤销应该是这个原因。

包含折叠标题全选后撤销状态异常的问题我这里可以重现了，感谢反馈。

@88250 88250 self-assigned this May 9, 2024
@88250 88250 changed the title 全选时，未能勾选折叠的内容，撤销操作报告状态异常需重建索引 Undo exception after folding heading is cut May 9, 2024
@88250 88250 added the Bug label May 9, 2024
@88250 88250 added this to the 3.0.14 milestone May 9, 2024
@allrobot
Copy link
Author

allrobot commented May 9, 2024 •
edited
Loading

我指的是思源中的扩展功能（设置 - 外观 - 代码片段），插件/代码片段可能会影响正常运行。后面插件生成的文本无法撤销应该是这个原因。

撤销管不到代码或插件生成的文本？我看代码编辑器能正常撤销的，可以参考一下：
pycharm64_WvoFo7Sc6c

——————————————————

希望设置新增一个选项，全选-包括折叠内容 [x]

@88250
Copy link
Member

88250 commented May 10, 2024

撤销管不到代码或插件生成的文本？

管不到的。

全选-包括折叠内容

短时间内估计不会实现这个需求了，见谅。

Vanessa219 added a commit that referenced this issue May 11, 2024
@Vanessa219
🐛 fix #11312
d12451e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@88250 88250

@Vanessa219 Vanessa219

Labels
Bug
Projects
None yet
Milestone
3.0.14
Development

No branches or pull requests
3 participants
@88250 @Vanessa219 @allrobot