Skip to content

Improve Shift+↑/↓ selection #11671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
allrobot opened this issue Jun 9, 2024 · 28 comments
Closed
3 tasks done

Improve Shift+↑/↓ selection #11671

allrobot opened this issue Jun 9, 2024 · 28 comments
Assignees
@Vanessa219
Labels
Enhancement
Milestone
3.1.0

Comments

@allrobot
Copy link

allrobot commented Jun 9, 2024 •
edited by 88250
Loading

代码块内部shift+↑无法选中上一行，而是选中整个代码块

Is there an existing issue for this?

  • I have searched the existing issues

Can the issue be reproduced with the default theme (daylight/midnight)?

  • I was able to reproduce the issue with the default theme

Could the issue be due to extensions?

  • I've ruled out the possibility that the extension is causing the problem.

Describe the problem

看图，已关闭所有插件仍然引发该问题

Expected result

shift无法选中一行代码，思源给选中该块了，俺寻思之前应该是正常选代码块里面的一行，不应该是全选的

Screenshot or screen recording presentation

SiYuan_jSikJWA3aa

Version environment

- Version: latest
- Operating System: win10
- Browser (if used):

Log file

siyuan.log

More information

No response
@88250 88250 changed the title 代码块内部shift+↑无法选中上一行，而是选中整个代码块 Improve Shift+↑ selection Jun 12, 2024
@88250 88250 added this to the 3.1.0 milestone Jun 12, 2024
@88250 88250 changed the title Improve Shift+↑ selection Improve Shift+↑/↓ selection Jun 12, 2024
Vanessa219 added a commit that referenced this issue Jun 12, 2024
@Vanessa219
🎨 fix #11671

Verified

This commit was signed with the committer’s verified signature.
Zuoqiu-Yingyi Yingyi / 颖逸
GPG key ID: 833DAD5428FF18A8
Verified
Learn about vigilant mode
38673b2
88250 pushed a commit that referenced this issue Jun 12, 2024
@Vanessa219 @88250
📝 #11671

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
d602a8f
@allrobot
Copy link
Author

SiYuan_Iqxt6DmSXp

@Vanessa219
Copy link
Member

md 中没有 kbd 的语法，没有的话都会使用标签。

@TCOTC
Copy link
Contributor

TCOTC commented Jun 17, 2024

但问题不是没粘贴出来吗？

@88250
Copy link
Member

88250 commented Jun 17, 2024

@allrobot 上次处理的是 code 元素 #11401 ，这次处理 kbd

@TCOTC
Copy link
Contributor

TCOTC commented Jun 17, 2024

这还是单独处理的吗？为什么不同时处理所有的行级元素呢？

@88250
Copy link
Member

88250 commented Jun 17, 2024

嗯，我就是这个意思，刚刚没打全 😂

@88250 88250 mentioned this issue Jun 17, 2024
Closed
@allrobot
Copy link
Author

md 中没有 kbd 的语法，没有的话都会使用标签。

@allrobot 上次处理的是 code 元素 #11401 ，这次处理 kbd

主要问题是历史剪切板的内容无法黏贴为MD格式，建议测一下所有的MD语法是不是都无法黏贴

@88250
Copy link
Member

88250 commented Jun 17, 2024 via email

@allrobot
Copy link
Author

为何在选取文本时，无论是普通文本还是代码块，使用“Shift+↑/↓”组合键都是全选的，而非仅选择光标上/下的普通文本？😅

SiYuan_n6XQiWO6eX

@TCOTC
Copy link
Contributor

TCOTC commented Jun 20, 2024 •
edited
Loading

使用 “Shift+↑/↓” 组合键都是全选的

@allrobot 我觉得你用的不是最新的版本 v3.1.0-dev3 ，我这里已经没这个问题了

@allrobot
Copy link
Author

allrobot commented Jun 20, 2024 via email

@88250
Copy link
Member

88250 commented Jun 20, 2024

@allrobot 试下打开开发者工具，Network 里面禁用缓存然后 Ctrl+R 刷新后再试试

@allrobot
Copy link
Author

@allrobot 试下打开开发者工具，Network 里面禁用缓存然后 Ctrl+R 刷新后再试试

chrome_0CClmJq53I.mp4

@TCOTC
Copy link
Contributor

TCOTC commented Jun 21, 2024 •
edited
Loading

@allrobot 在开发者工具里 Ctrl+R 重载整个界面再看看

@allrobot
Copy link
Author

allrobot commented Jun 21, 2024 •
edited
Loading

@allrobot 在开发者工具里 Ctrl+R 重载整个界面再看看

快捷键找了下，siyuan重载快捷键是ctrl+shift+r，开发者工具是ctrl+r

重载了还是全选

@TCOTC
Copy link
Contributor

TCOTC commented Jun 21, 2024 •
edited
Loading

@allrobot 文档导出为 .sy.zip 上传一下，我这边试试

@allrobot
Copy link
Author

@allrobot 文档导出为 .sy.zip 上传一下，我这边试试

av1an文档.sy.zip

@TCOTC
Copy link
Contributor

TCOTC commented Jun 21, 2024

很难说你那里是什么情况，我这里挺正常：

GIF

@allrobot
Copy link
Author

该issue未得到修复，需open issue

@TCOTC
Copy link
Contributor

TCOTC commented Jun 21, 2024

@allrobot 真的确认是最新的 dev 版吗？安装昨天发布的 dev 版再试试？

@allrobot
Copy link
Author

allrobot commented Jun 21, 2024 •
edited
Loading

@allrobot 真的确认是最新的 dev 版吗？安装昨天发布的 dev 版再试试？

安装了，还是不太行，普通块和代码块光标位置如果是末尾，向上会全选的
keycastow_dG6N0KOPMY

普通块
keycastow_FzjdqLHT08

@TCOTC
Copy link
Contributor

TCOTC commented Jun 21, 2024

@Vanessa219 Shift+↓ 是正常的，Shift+↑ 有点问题：

default.webm

@Vanessa219
Copy link
Member

Mac 下无法重现， @88250 Windows 下看一下。

@TCOTC
Copy link
Contributor

TCOTC commented Jun 22, 2024

@88250 现在 Shift+↓ 也有问题了：

default.webm

@88250
Copy link
Member

88250 commented Jun 23, 2024

@TCOTC @Vanessa219 我这里段落块中 Shift+↓ 没有问题，Shift+↑ 有问题；但在代码块中，↑/↓ 都有问题。

@88250 88250 reopened this Jun 23, 2024
@TCOTC
Copy link
Contributor

TCOTC commented Jun 23, 2024

这怎么做到在每台设备上的表现不同的

@88250
Copy link
Member

88250 commented Jun 23, 2024 via email

Vanessa219 added a commit that referenced this issue Jun 29, 2024
@Vanessa219
🎨 fix #11671
41fb731
@Vanessa219
Copy link
Member

还麻烦再看看

Vanessa219 added a commit that referenced this issue Jun 29, 2024
@Vanessa219
🎨 fix #11671
69fb991
copialot pushed a commit to copialot/siyuan that referenced this issue Aug 3, 2024
@Vanessa219
🎨 fix siyuan-note#11671
04675b6
copialot pushed a commit to copialot/siyuan that referenced this issue Aug 3, 2024
@Vanessa219
📝 siyuan-note#11671
26115d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vanessa219 Vanessa219

Labels
Enhancement
Projects
None yet
Milestone
3.1.0
Development

No branches or pull requests
4 participants
@88250 @Vanessa219 @allrobot @TCOTC