Skip to content

Improve spaced repetition loading performance #11927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
Jiangshuon opened this issue Jul 9, 2024 · 5 comments
Closed
3 tasks done

Improve spaced repetition loading performance #11927

Jiangshuon opened this issue Jul 9, 2024 · 5 comments
Assignees
@88250
Labels
Enhancement
Milestone
3.1.1

Comments

@Jiangshuon
Copy link

Jiangshuon commented Jul 9, 2024 •
edited by 88250
Loading

间隔重复打开和复习变得尤其缓慢，需要4、5秒才能响应

Is there an existing issue for this?

  • I have searched the existing issues

Can the issue be reproduced with the default theme (daylight/midnight)?

  • I was able to reproduce the issue with the default theme

Could the issue be due to extensions?

  • I've ruled out the possibility that the extension is causing the problem.

Describe the problem

。。

Expected result

。。

Screenshot or screen recording presentation

No response

Version environment

- Version: 最新
- Operating System: 手机和pc
- Browser (if used):

Log file

。。

More information

No response
@TCOTC
Copy link
Contributor

TCOTC commented Jul 9, 2024

我电脑也是

@hep-cogth
Copy link

hep-cogth commented Jul 9, 2024 •
edited
Loading

You can profile with devtools, and observed a getRiffDueCards with large amount of sequential getBlockAttrs.

The performance regression is due to change in blocktree storage, which leads to minor conflict with sy-tomato-plugin

@IAliceBobI
Copy link

@abd-liac 插件在新版思源中，用的不是 getBlockAttrs ，而是batchGetBlockAttrs,

但瓶颈不是 batchGetBlockAttrs 这里，是getRiffDueCards ，读取到期卡特别慢。

@HibernalGlow
Copy link

HibernalGlow commented Jul 9, 2024 •
edited
Loading

问题出现在重构块树存储后，回到在此之前的dev无问题，后续版本也都没有改进，闪卡几乎处于不能用的状态

@TCOTC
Copy link
Contributor

TCOTC commented Jul 9, 2024

我没用插件，同样是这个速度

@88250 88250 self-assigned this Jul 9, 2024
@88250 88250 added this to the 3.1.1 milestone Jul 9, 2024
@88250 88250 changed the title 间隔重复打开和复习变得尤其缓慢，需要4、5秒才能响应 Improve spaced repetition loading performance Jul 9, 2024
88250 added a commit that referenced this issue Jul 9, 2024
@88250
⚡ Improve spaced repetition loading performance #11927

Verified

This commit was signed with the committer’s verified signature.
88250 D
GPG key ID: 86211BA83DF03017
Verified
Learn about vigilant mode
3d36355
@88250 88250 closed this as completed Jul 9, 2024
88250 added a commit that referenced this issue Jul 10, 2024
@88250
⚡ Improve spaced repetition loading performance #11927
f566ef4
@TCOTC TCOTC mentioned this issue Jul 12, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@88250 88250

Labels
Enhancement
Projects
None yet
Milestone
3.1.1
Development

No branches or pull requests
6 participants
@88250 @IAliceBobI @Jiangshuon @TCOTC @hep-cogth @HibernalGlow