Skip to content

Multiple-select list items remain selected after indent or outdent #12209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TCOTC opened this issue Aug 7, 2024 · 4 comments
Closed

Multiple-select list items remain selected after indent or outdent #12209

TCOTC opened this issue Aug 7, 2024 · 4 comments
Assignees
@Vanessa219
Labels
Enhancement
Milestone
3.1.16

Comments

@TCOTC
Copy link
Contributor

TCOTC commented Aug 7, 2024 •
edited
Loading

多选列表项，列表的缩进不能连续调整，需要不断地选中：

default.webm

如果只选中了一个列表项的所有子块，就是正常的：

default.webm
@TCOTC TCOTC changed the title 多选列表项，按 (Shift+)Tab 之后不应该取消选中 🐛 多选列表项，按 (Shift+)Tab 之后不应该取消选中 Aug 10, 2024
@88250 88250 changed the title 🐛 多选列表项，按 (Shift+)Tab 之后不应该取消选中 多选列表项，按 (Shift+)Tab 之后不应该取消选中 Aug 11, 2024
@88250
Copy link
Member

88250 commented Dec 17, 2024

图二现在不支持了，要扩选到列表项这一级，操作以后都是取消选中，但是实际上是可以继续 Tab/Shift+Tab 的。

@88250 88250 closed this as completed Dec 17, 2024
@TCOTC
Copy link
Contributor Author

TCOTC commented Dec 17, 2024

比如我想把 3 4 5 都移到第一层，目前只能按一次选一次再继续按：

video.webm

@88250
Copy link
Member

88250 commented Dec 18, 2024

@Vanessa219

@Vanessa219 Vanessa219 self-assigned this Dec 18, 2024
@Vanessa219 Vanessa219 added this to the 3.1.16 milestone Dec 18, 2024
@Vanessa219 Vanessa219 changed the title 多选列表项，按 (Shift+)Tab 之后不应该取消选中 Multiple-select list items remain selected after indent or outdent Dec 18, 2024
Vanessa219 added a commit that referenced this issue Dec 18, 2024
@Vanessa219
🎨 #12209

Verified

This commit was signed with the committer’s verified signature.
88250 D
GPG key ID: 86211BA83DF03017
Verified
Learn about vigilant mode
20c7535
@Wetoria
Copy link

Wetoria commented Dec 19, 2024 •
edited
Loading

选择列表项的所有子元素时，可以考虑缩进列表项。

下面这种选择的情况，不能通过 Tab 进行缩进。
image

目前只能这种的可以缩进。
image

应该是代码里只判断了选中的块是不是都是列表项吧？

如果选择的是某一个列表项的所有子块，是不是可以考虑视作选择了整个列表项？

在下图这种选择的情况下，使用 Tab 缩进时，看作是第二张图这种选中了整个列表项的效果。
image

image

如果是下面这种只选择了部分子块，则不进行处理

image

@Vanessa219 Vanessa219 mentioned this issue Dec 19, 2024
Closed
EightDoor added a commit to EightDoor/siyuan that referenced this issue Dec 24, 2024
@EightDoor
Merge commit '7d34a87da4c2c5f2324a2dee9d8da1f576f415fe'
ed9ac35 
* commit '7d34a87da4c2c5f2324a2dee9d8da1f576f415fe': (234 commits)
  🎨 tag 颜色
  🔖 Release v3.1.16
  📝 Update changelogs
  🚨
  🎨 siyuan-note#12209
  🎨 Improve tag escaping
  🎨 siyuan-note#13524
  🎨 siyuan-note#13523
  🔥 Remove Sentry reporting diagnostic data siyuan-note#13522
  🎨 Improve exporting data siyuan-note#13500
  🔥 Remove Sentry reporting diagnostic data siyuan-note#13522
  📝 Update changelogs
  🎨 siyuan-note#13522
  🎨 siyuan-note#13241
  🎨 siyuan-note#13241
  🎨 search
  🎨 siyuan-note#12335
  🎨 Improve exporting data siyuan-note#13500
  🎨 siyuan-note#13440
  🎨 Improve exporting data siyuan-note#13500
  ...
mouyase pushed a commit to mouyase/siyuan that referenced this issue Feb 28, 2025
@Vanessa219 @mouyase
🎨 siyuan-note#12209

Verified

This commit was signed with the committer’s verified signature.
88250 D
GPG key ID: 86211BA83DF03017
Verified
Learn about vigilant mode
594d757
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vanessa219 Vanessa219

Labels
Enhancement
Projects
None yet
Milestone
3.1.16
Development

No branches or pull requests
4 participants
@88250 @Vanessa219 @Wetoria @TCOTC