Skip to content

Improve HTML list clipping #12237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 of 4 tasks
TCOTC opened this issue Aug 11, 2024 · 10 comments
Closed
3 of 4 tasks

Improve HTML list clipping #12237

TCOTC opened this issue Aug 11, 2024 · 10 comments
Assignees
@88250
Labels
Enhancement
Milestone
3.1.4

Comments

@TCOTC
Copy link
Contributor

TCOTC commented Aug 11, 2024 •
edited
Loading

01 剪藏：https://ld246.com/article/1723388814745

  • 有些内容是应该在列表内的：

    image

  • kbd 元素没有正确剪藏：

    image

  • 代码块末尾都有多余的换行和零宽空格：

    image

02 复制 Markdown 粘贴：https://ld246.com/article/raw/1723388814745

  • 这部分粘贴出来感觉很怪：

    image
@88250
Copy link
Member

88250 commented Aug 12, 2024

@88250 88250 closed this as completed Aug 12, 2024
@TCOTC
Copy link
Contributor Author

TCOTC commented Aug 12, 2024

没道理不能适配啊

01 这个子元素剪藏之后应该在列表里的：

image

02 kbd 元素的剪藏也应该是能改进的：

image

03 这个 code 元素里面明明没有零宽空格是怎么剪藏出来的：

image

04 还有这个代码块粘贴之后会变成行级代码：

# 标题

    ```shell
    这里是个代码块
    ```

@88250
Copy link
Member

88250 commented Aug 12, 2024

没道理不能适配啊

没有必要，因为链滴已经提供了 Markdown 文本了。

@TCOTC
Copy link
Contributor Author

TCOTC commented Aug 12, 2024 •
edited
Loading

01 如果链滴遇到这些问题，那其他网页也是一样的，问题不会只是链滴有，还是要改进才行

https://cs50.harvard.edu/x/2024/notes/1/

image

image

02 Markdown 粘贴出来也不对啊，还是得靠剪藏

@88250 88250 changed the title 改进剪藏、粘贴 Improve HTML list clipping Aug 12, 2024
@88250 88250 self-assigned this Aug 12, 2024
@88250
Copy link
Member

88250 commented Aug 12, 2024

  • 列表的问题可以重现
  • 复制 Markdown 纯文本后粘贴

@TCOTC
Copy link
Contributor Author

TCOTC commented Aug 12, 2024

那 kbd 元素的剪藏呢？

@TCOTC
Copy link
Contributor Author

TCOTC commented Aug 12, 2024

还有这种代码块粘贴之后会变成行级代码也没法解决：

# 标题

    ```shell
    这里是个代码块
    ```

@88250
Copy link
Member

88250 commented Aug 12, 2024

kbd 的问题单独提 issue 吧

@TCOTC
Copy link
Contributor Author

TCOTC commented Aug 12, 2024

代码块 Markdown 的问题能解决吗？

@TCOTC TCOTC mentioned this issue Aug 12, 2024
Closed
@88250
Copy link
Member

88250 commented Aug 12, 2024

思源不支持缩进风格的代码块，所以会将缩进风格的代码块转换为行级代码。

@88250 88250 added this to the 3.1.4 milestone Aug 12, 2024
88250 added a commit to 88250/lute that referenced this issue Aug 12, 2024
@88250
🎨 Improve HTML list/code clipping siyuan-note/siyuan#12237

Verified

This commit was signed with the committer’s verified signature.
88250 D
GPG key ID: 86211BA83DF03017
Verified
Learn about vigilant mode
198dd12
88250 added a commit that referenced this issue Aug 12, 2024
@88250
🎨 Improve clipping #12237 #10987
63083ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@88250 88250

Labels
Enhancement
Projects
None yet
Milestone
3.1.4
Development

No branches or pull requests
2 participants
@88250 @TCOTC