Skip to content

Improve search highlighting #13178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TCOTC opened this issue Nov 18, 2024 · 3 comments
Closed

Improve search highlighting #13178

TCOTC opened this issue Nov 18, 2024 · 3 comments
Assignees
@Vanessa219
Labels
Enhancement
Milestone
3.1.14

Comments

@TCOTC
Copy link
Contributor

TCOTC commented Nov 18, 2024 •
edited by 88250
Loading

更换搜索高亮的实现方式

目前用 data-type="search-mark" 会影响很多行级元素的自定义样式，比如 #12985 (comment) ：

image

image

以及目前的方式没法高亮代码块内的代码
@TCOTC TCOTC mentioned this issue Nov 18, 2024
Closed
Vanessa219 added a commit that referenced this issue Nov 28, 2024
@Vanessa219
🎨 #13178

Verified

This commit was signed with the committer’s verified signature.
bagder Daniel Stenberg
GPG key ID: 5CC908FDB71E12C2
Verified
Learn about vigilant mode
f7fea18
@Vanessa219 Vanessa219 added this to the 3.1.14 milestone Nov 28, 2024
Vanessa219 added a commit that referenced this issue Nov 28, 2024
@Vanessa219
🎨 #13178
c315fce
@88250 88250 changed the title 更换搜索高亮的实现方式 Improve search highlighting Nov 28, 2024
@TCOTC
Copy link
Contributor Author

TCOTC commented Dec 1, 2024

话说这个高亮好像没什么区别，还是会把行级元素切碎：

image

@88250 88250 self-assigned this Dec 1, 2024
@88250
Copy link
Member

88250 commented Dec 1, 2024

等会我再改进一下看看

@88250 88250 reopened this Dec 1, 2024
@88250 88250 removed their assignment Dec 2, 2024
@88250 88250 mentioned this issue Dec 3, 2024
Closed
@88250
Copy link
Member

88250 commented Dec 3, 2024

后续在 #13343 中继续改进。

@88250 88250 closed this as completed Dec 3, 2024
mouyase pushed a commit to mouyase/siyuan that referenced this issue Feb 28, 2025
@Vanessa219 @mouyase
🎨 siyuan-note#13178
c08dbd8
mouyase pushed a commit to mouyase/siyuan that referenced this issue Feb 28, 2025
@Vanessa219 @mouyase
🎨 siyuan-note#13178
28602fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vanessa219 Vanessa219

Labels
Enhancement
Projects
None yet
Milestone
3.1.14
Development

No branches or pull requests
3 participants
@88250 @Vanessa219 @TCOTC