Skip to content

Remove Add and Remove buttons for S3/WebDAV cloud sync directory settings #13682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TCOTC opened this issue Dec 31, 2024 · 3 comments
Closed

Remove Add and Remove buttons for S3/WebDAV cloud sync directory settings #13682

TCOTC opened this issue Dec 31, 2024 · 3 comments
Assignees
@88250
Labels
Enhancement
Milestone
3.1.19

Comments

@TCOTC
Copy link
Contributor

TCOTC commented Dec 31, 2024 •
edited by 88250
Loading

去掉 S3 和 WebDAV 的云端同步目录 添加 和 删除 按钮

功能也没做，直接去掉按钮好了。

偶尔会被误解 https://ld246.com/article/1735205284783
@musnows
Copy link

musnows commented Dec 31, 2024

同意，另外建议S3的云端同步目录选项框也直接去掉，因为S3的bucket已经写死在配置里面了，这个前端的选择应该没有意义吧。

@TCOTC
Copy link
Contributor Author

TCOTC commented Dec 31, 2024

印象中腾讯云是可以选的

@musnows
Copy link

musnows commented Dec 31, 2024 •
edited
Loading

印象中腾讯云是可以选的

s3配置里面有一个bucket，底部这个就是个冗余的选项，如果可以选，那s3配置里面填的bucket有啥意义？最好是直接删除掉，一律以s3配置的bucket为准，避免产生歧义。而且S3和WEBDAV也不一样，为了避免出现配置和同步错误，个人认为也不应该出现“某个bucket中的目录”这样的选项。

@88250 88250 self-assigned this Dec 31, 2024
@88250 88250 added this to the 3.1.19 milestone Dec 31, 2024
@88250 88250 changed the title 去掉 S3 和 WebDAV 的云端同步目录 添加 和 删除 按钮 Remove Add and Remove buttons for S3/WebDAV cloud sync directory settings Dec 31, 2024
@88250 88250 changed the title Remove Add and Remove buttons for S3/WebDAV cloud sync directory settings Remove Add and Remove buttons for S3/WebDAV/Local cloud sync directory settings Jan 1, 2025
@88250 88250 changed the title Remove Add and Remove buttons for S3/WebDAV/Local cloud sync directory settings Remove Add and Remove buttons for S3/WebDAV cloud sync directory settings Jan 1, 2025
88250 added a commit to siyuan-note/dejavu that referenced this issue Jan 1, 2025
@88250
🎨 Just list the S3 bucket configured siyuan-note/siyuan#13682
Loading
Loading status checks…
eb8ad43
88250 added a commit that referenced this issue Jan 1, 2025
@88250
🎨 Remove Add and Remove buttons for S3/WebDAV cloud sync director…
47e6e8b 
…y settings #13682
88250 added a commit that referenced this issue Jan 1, 2025
@88250
🎨 Remove Add and Remove buttons for S3/WebDAV cloud sync director…
6d7feb4 
…y settings #13682
@88250 88250 closed this as completed Jan 1, 2025
mouyase pushed a commit to mouyase/siyuan that referenced this issue Feb 28, 2025
@88250 @mouyase
🎨 Remove Add and Remove buttons for S3/WebDAV cloud sync director…
00e7253 
…y settings siyuan-note#13682
mouyase pushed a commit to mouyase/siyuan that referenced this issue Feb 28, 2025
@88250 @mouyase
🎨 Remove Add and Remove buttons for S3/WebDAV cloud sync director…
7e6eac1 
…y settings siyuan-note#13682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@88250 88250

Labels
Enhancement
Projects
None yet
Milestone
3.1.19
Development

No branches or pull requests
3 participants
@88250 @TCOTC @musnows