Skip to content

Lacks the entry to edit mermaid on mobile #13934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TCOTC opened this issue Jan 24, 2025 · 0 comments
Closed

Lacks the entry to edit mermaid on mobile #13934

TCOTC opened this issue Jan 24, 2025 · 0 comments
Assignees
@Vanessa219
Labels
Bug
Milestone
3.1.23

Comments

@TCOTC
Copy link
Contributor

TCOTC commented Jan 24, 2025 •
edited by 88250
Loading

移动端缺少编辑 mermaid 的入口

https://ld246.com/article/1722852589159

插入了不能再编辑

Image

siyuan/app/src/protyle/render/util.ts

Lines 1 to 15 in f1993e1

export const genIconHTML = (element?: false|HTMLElement) => {
let enable = true;
if (element) {
const readonly = element.getAttribute("contenteditable");
if (typeof readonly === "string") {
enable = element.getAttribute("contenteditable") === "true";
} else {
return '<div class="protyle-icons"></div>';
}
}
return `<div class="protyle-icons">
<span aria-label="${window.siyuan.languages.edit}" class="b3-tooltips__nw b3-tooltips protyle-icon protyle-icon--first protyle-action__edit${enable ? "" : " fn__none"}"><svg><use xlink:href="#iconEdit"></use></svg></span>
<span aria-label="${window.siyuan.languages.more}" class="b3-tooltips__nw b3-tooltips protyle-icon protyle-action__menu protyle-icon--last${enable ? "" : " protyle-icon--first"}"><svg><use xlink:href="#iconMore"></use></svg></span>
</div>`;
};

Vanessa219 added a commit that referenced this issue Feb 14, 2025
@Vanessa219
🎨 #13934
d6b597c
@Vanessa219 Vanessa219 added the Bug label Feb 14, 2025
@Vanessa219 Vanessa219 added this to the 3.1.23 milestone Feb 14, 2025
@88250 88250 changed the title 移动端缺少编辑 mermaid 的入口 Lacks the entry to edit mermaid on mobile Feb 15, 2025
mouyase pushed a commit to mouyase/siyuan that referenced this issue Feb 28, 2025
@Vanessa219 @mouyase
🎨 siyuan-note#13934
48e2bc0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vanessa219 Vanessa219

Labels
Bug
Projects
None yet
Milestone
3.1.23
Development

No branches or pull requests
2 participants
@Vanessa219 @TCOTC