Skip to content

Improve the centering and line wrapping of database primary key emojis #13940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TCOTC opened this issue Jan 25, 2025 · 9 comments
Closed

Improve the centering and line wrapping of database primary key emojis #13940

TCOTC opened this issue Jan 25, 2025 · 9 comments
Assignees
@Vanessa219
Labels
Enhancement
Milestone
3.1.23

Comments

@TCOTC
Copy link
Contributor

TCOTC commented Jan 25, 2025 •
edited by 88250
Loading

改进数据库主键表情居中和换行

文档树：

  • emoji 图标比自定义图标更宽（关联回帖）：

    video.webm

数据库：

  • 自定义图标宽度和 emoji 图标不一致，应该统一都用 min-width: calc(1.625em - 8px);

  • 自定义图标位置偏下：

    video.webm
@TCOTC TCOTC changed the title 文档树图标不等宽导致标题对不齐 文档树、数据库主键图标问题 Feb 2, 2025
@Vanessa219
Copy link
Member

emoji 的会根据操作系统和图标字体不同而不同

@TCOTC
Copy link
Contributor Author

TCOTC commented Feb 13, 2025

那自定义图标的问题能解决一下吗

@Vanessa219
Copy link
Member

自定义的宽度都是一致的

@TCOTC
Copy link
Contributor Author

TCOTC commented Feb 13, 2025

自定义图标宽度和 emoji 图标不一致，应该统一都用 min-width: calc(1.625em - 8px);

自定义图标位置偏下

这两个数据库的不能改一下吗

@Vanessa219
Copy link
Member

emoji 和系统、字体相关，用了宽度也无法限制，自定义图标偏下指的是数据库下较大的字体还是？

@TCOTC
Copy link
Contributor Author

TCOTC commented Feb 13, 2025

min-width 至少能对齐一点。

自定义图标是因为没有垂直居中所以会偏下

@Vanessa219
Copy link
Member

用了 min-width 当表情过窄时，右侧留白会过多。

@Vanessa219 Vanessa219 changed the title 文档树、数据库主键图标问题 改进数据库主键表情居中和换行 Feb 14, 2025
@Vanessa219 Vanessa219 added this to the 3.2.0 milestone Feb 14, 2025
Vanessa219 added a commit that referenced this issue Feb 14, 2025
@Vanessa219
🎨 #13940
0f67a3a
@88250 88250 modified the milestones: 3.2.0, 3.1.23 Feb 14, 2025
@88250 88250 changed the title 改进数据库主键表情居中和换行 Improve the centering and line wrapping of database primary key emojis Feb 14, 2025
@TCOTC
Copy link
Contributor Author

TCOTC commented Feb 15, 2025

自定义图标在字段名上有点不对齐：

Image

Vanessa219 added a commit that referenced this issue Feb 16, 2025
@Vanessa219
🎨#13940
3750c84
mouyase pushed a commit to mouyase/siyuan that referenced this issue Feb 28, 2025
@Vanessa219 @mouyase
🎨 siyuan-note#13940
8fd0ac5
mouyase pushed a commit to mouyase/siyuan that referenced this issue Feb 28, 2025
@Vanessa219 @mouyase
🎨siyuan-note#13940
8b6f1ab
@TCOTC
Copy link
Contributor Author

TCOTC commented Mar 16, 2025

@Vanessa219 我这里感觉还有 1px 没对齐

Image

把这里改成 -4px 好像就对齐了：

Image

Vanessa219 added a commit that referenced this issue Mar 17, 2025
@Vanessa219
🎨 #13940
3a05e87
EightDoor added a commit to EightDoor/siyuan that referenced this issue Mar 19, 2025
@EightDoor
Merge commit '0b0c27b0bad3e2a073f61ed28c6ce76d2f2b4b07'
05eeb0b 
* commit '0b0c27b0bad3e2a073f61ed28c6ce76d2f2b4b07': (139 commits)
  🔖 Release v3.1.25
  🎨 siyuan-note#14380
  🎨 siyuan-note#14380
  📝 Update changelogs
  🎨 Improve HTML clipping siyuan-note#14386
  🎨 Supports assets settings on mobile siyuan-note#13930 siyuan-note#13622 (siyuan-note#14380)
  🎨 siyuan-note#14326   #issuecomment-2727527008
  🎨 siyuan-note#14370
  🎨 siyuan-note#14370
  🎨 siyuan-note#14309
  🎨 siyuan-note#13940
  ⬆️ Upgrade deps
  🎨 siyuan-note#14370
  📝 Update changelogs
  🎨 siyuan-note#14377
  🎨 siyuan-note#14370
  📝 Update changelogs
  🎨 Improve query embed block auto refresh siyuan-note#14370
  🎨 When deleting a referenced definition block, a pop-up window will prompt the user siyuan-note#13396
  🎨 siyuan-note#14370
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vanessa219 Vanessa219

Labels
Enhancement
Projects
None yet
Milestone
3.1.23
Development

No branches or pull requests
3 participants
@88250 @Vanessa219 @TCOTC