Skip to content

Improve appearance mode switch #14157

Closed
Closed
@TCOTC

Description

@TCOTC

外观模式切出 跟随系统 模式的异常

异常 01:使界面重载

  1. 系统是日间模式
  2. 思源的明亮主题设置为默认主题
  3. 思源的暗黑主题设置为集市第三方主题
  4. 切换思源的外观模式:暗黑 → 跟随系统 → 暗黑(界面重载)
video.webm

Activity

88250

88250 commented on Feb 20, 2025

@88250
Member

使用了 theme.js 的主题需要完整重载界面。

TCOTC

TCOTC commented on Feb 20, 2025

@TCOTC
ContributorAuthor

不是早就不重载了吗 #8178

明亮模式和暗黑模式来回切换一点问题都没有,但切换到跟随系统再切换回来就重载了

88250

88250 commented on Feb 20, 2025

@88250
Member
Vanessa219

Vanessa219 commented on Feb 20, 2025

@Vanessa219
Member

没有覆写 window.destroyTheme 这个还是会重载的

TCOTC

TCOTC commented on Feb 20, 2025

@TCOTC
ContributorAuthor

啥意思?

Vanessa219

Vanessa219 commented on Feb 20, 2025

@Vanessa219
Member

具体可参看 #8178

都用默认的主题下切换主题;使用跟随系统后切换系统外观模式无法重现。

TCOTC

TCOTC commented on Feb 20, 2025

@TCOTC
ContributorAuthor

没看出什么来,但 暗黑 → 跟随系统 → 暗黑(界面重载) 应该不是预期行为

TCOTC

TCOTC commented on Feb 20, 2025

@TCOTC
ContributorAuthor

还有下面这种明亮暗黑主题对调的情况,会出现主题不卸载的问题:


异常 02:主题不卸载

明亮:第三方主题
暗黑:默认主题

切换顺序:明亮 → 暗黑 → 跟随系统 →(移除了主题JS,但没有卸载主题)→ 暗黑 → 明亮


Whisper 主题在加载的时候会输出 Whisper: loaded,卸载的时候会输出 Whisper: unloaded,录屏 0:21 处从 跟随系统 切换到 暗黑 时没有输出 Whisper: unloaded,说明主题没有成功卸载:

video.webm

主题 JS 加载了两次,因此产生了冲突:

Image

changed the title [-]外观模式切换会使界面重载[/-] [+]外观模式切出 `跟随系统` 模式的异常[/+] on Feb 20, 2025
Vanessa219

Vanessa219 commented on Feb 21, 2025

@Vanessa219
Member

没看出什么来,但 暗黑 → 跟随系统 → 暗黑(界面重载) 应该不是预期行为

这样不是预期行为么?

Jietu20250221-173657-HD.mp4
TCOTC

TCOTC commented on Feb 21, 2025

@TCOTC
ContributorAuthor

异常 01:使界面重载

  1. 系统是日间模式
  2. 思源的明亮主题设置为默认主题
  3. 思源的暗黑主题设置为集市第三方主题
  4. 切换思源的外观模式:暗黑 → 跟随系统 → 暗黑(界面重载)

暗黑主题要设置为集市第三方主题。切换回暗黑模式的时候会重载显示 Logo

added this to the 3.1.23 milestone on Feb 22, 2025
changed the title [-]外观模式切出 `跟随系统` 模式的异常[/-] [+]Improve appearance mode switch[/+] on Feb 22, 2025
Vanessa219

Vanessa219 commented on Feb 22, 2025

@Vanessa219
Member

异常1,2 应该是同一个问题造成的,和 #14167 说的是同一个事情么?

added a commit that references this issue on Feb 22, 2025
TCOTC

TCOTC commented on Feb 22, 2025

@TCOTC
ContributorAuthor

应该不是同一个事情,那个不需要跟随系统就能复现

added a commit that references this issue on Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @88250@Vanessa219@TCOTC

      Issue actions

        Improve appearance mode switch · Issue #14157 · siyuan-note/siyuan