Skip to content

Improve plugin compatibility of embed blocks #14405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TCOTC opened this issue Mar 20, 2025 · 17 comments
Closed

Improve plugin compatibility of embed blocks #14405

TCOTC opened this issue Mar 20, 2025 · 17 comments
Assignees
@Vanessa219
Labels
Enhancement
Milestone
3.1.26

Comments

@TCOTC
Copy link
Contributor

TCOTC commented Mar 20, 2025 •
edited by 88250
Loading

改进嵌入块对插件的兼容

video.webm
Vanessa219 added a commit that referenced this issue Mar 24, 2025
@Vanessa219
🎨 #14405

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 136F30F901A2231D
Learn about vigilant mode
ff2c6f8
@Vanessa219 Vanessa219 changed the title sy-query-view 插件异常 改进嵌入块对插件的兼容 Mar 24, 2025
@Vanessa219 Vanessa219 added this to the 3.1.26 milestone Mar 24, 2025
@Vanessa219
Copy link
Member

只有刷新这个问题么？

@88250 88250 changed the title 改进嵌入块对插件的兼容 Improve plugin compatibility of embed blocks Mar 24, 2025
@TCOTC
Copy link
Contributor Author

TCOTC commented Mar 24, 2025

再看看这个：

  • 控制台报错
  • 文档关闭再打开会一直转圈
video.webm

@Vanessa219
Copy link
Member

我用的是群里面的包，没有这个问题，我发你看看。

package.zip

@TCOTC
Copy link
Contributor Author

TCOTC commented Mar 24, 2025

还是有这个问题，你把这些复制粘贴到文档里再试一下看看：

# 123123

# 234234

@### 23

4

234

## 324234

234234

# 23234

# 234234

234#123#

# 234234

# 234234

# 234234

3

# 234234

@Vanessa219
Copy link
Member

正常的

Image

@TCOTC
Copy link
Contributor Author

TCOTC commented Mar 24, 2025

控制台呢？关掉文档重新打开呢？

@Vanessa219
Copy link
Member

没有错，都是好的。

EightDoor added a commit to EightDoor/siyuan that referenced this issue Mar 25, 2025
@EightDoor
Merge commit '1317020c1791edf440da7f836d366567e03dd843'

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 136F30F901A2231D
Learn about vigilant mode
Loading
Loading status checks…
4487fa2 
* commit '1317020c1791edf440da7f836d366567e03dd843': (65 commits)
  🔖 Release v3.1.26
  🎨 Add index `idx_attributes_block_id` https://ld246.com/article/1742827508465
  📝 Supports append text by shortcuts to the dailynote doc on Android siyuan-note#14414
  🎨 Support in-app purchase PRO Features and Subscription on iOS siyuan-note#14159
  📝 Supports append text by shortcuts to the dailynote doc on Android siyuan-note#14414
  🎨
  📝 Update changelogs
  🎨 siyuan-note#14372
  🎨 siyuan-note#14364
  🎨 siyuan-note#14405
  🐛 siyuan-note#14326
  🎨 siyuan-note#14326
  🎨 siyuan-note#14156
  ⬆️ Upgrade lute siyuan-note#14397
  ⬆️ Upgrade lute siyuan-note#14424
  🎨 siyuan-note#14395
  🎨 siyuan-note#14406
  🎨 siyuan-note#14428
  ⬆️ Upgrade lute siyuan-note#14424
  🎨 Support indented code block syntax when importing Markdown siyuan-note#14429
  ...
@frostime frostime mentioned this issue Mar 25, 2025
Closed
@frostime
Copy link
Contributor

我刚刚更新思源测试了一下，上一周的大问题解决了，看着也能正常渲染。

我还需要在自己测试试用一段时间看看有没有别的问题。

有时候控制台还是会有奇怪的报错。

Image

一旦出现这种错误，再次刷新的时候就会在顶部出现错误。

Image

不过好在，只要继续多刷新一下，就又会恢复正常，所以不算什么恶性 bug。

大概发现了复现的规律，只要嵌入块的代码存在错误（比如图中有一个拼写的错误）导致代码无法正常运行，就会出现上面的情况。

Image

@frostime
Copy link
Contributor

目前看大问题没有发现，我再自己用几天没问题的话就重新上架回去吧。

Vanessa219 added a commit that referenced this issue Mar 26, 2025
@Vanessa219
🎨 #14405
b8a60d9
@Vanessa219
Copy link
Member

改进了一下错误提示，但是光标错误的问题无法重现。

@frostime
Copy link
Contributor

frostime commented Mar 26, 2025 •
edited
Loading

TOC 前面提到的转圈我这里也遇到了

Image

而且很奇怪的是，悬浮链接的时候，Protyle 里面是正确渲染的，结果点击到文档里反而出问题不显示了。

Image

这个问题目前中低概率随机出现，暂时不知道如何复现。还需要再观察一段时间。

Image

@Vanessa219
Copy link
Member

嵌入块有错误就会打不开了，但是 range 的错误我这里还是重现不了

@TCOTC
Copy link
Contributor Author

TCOTC commented Mar 26, 2025

D 那里能吗

@Vanessa219
Copy link
Member

不对，好像不能打开这个问题有点奇怪，刚才重现了，现在又不行了。

@Vanessa219
Copy link
Member

应该可以了，麻烦再试试。

Vanessa219 added a commit that referenced this issue Mar 26, 2025
@Vanessa219
🎨 #14405
01d1092
@TCOTC
Copy link
Contributor Author

TCOTC commented Mar 26, 2025

  • 控制台报错
  • 文档关闭再打开会一直转圈

这两个我这里测试没问题了

@frostime
Copy link
Contributor

我后面再测试一下，没啥问题的话那应该就可以解决了。👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vanessa219 Vanessa219

Labels
Enhancement
Projects
None yet
Milestone
3.1.26
Development

No branches or pull requests
3 participants
@Vanessa219 @frostime @TCOTC