Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

支持行级备注 #174

Closed
lvzhp opened this issue Oct 6, 2020 · 5 comments
Closed

支持行级备注 #174

lvzhp opened this issue Oct 6, 2020 · 5 comments
Assignees
@88250 @Vanessa219
Labels
Feature
Milestone
2.2.0

Comments

@lvzhp
Copy link

lvzhp commented Oct 6, 2020

选中 一部分文字，进行悬浮注释。
类似于脚注，但是不是标注在底部，而是在注释的文字旁有个图标，鼠标移上去，即可显示注释的内容。
@88250
Copy link
Member

88250 commented Oct 6, 2020

行级内容的备注（或者叫批注）暂时没有，但块级内容（针对内容块）的备注已有计划，请看 #64

@88250 88250 changed the title 增添 悬浮注释 功能 行级内容备注 Oct 6, 2020
@88250 88250 added the Feature label Jan 8, 2021
@88250 88250 mentioned this issue Feb 27, 2021
Closed
@88250
Copy link
Member

88250 commented Apr 30, 2021

行级的暂时不考虑了，谢谢。

@88250 88250 closed this as completed Apr 30, 2021
@88250 88250 removed the Feature label Apr 30, 2021
@88250 88250 changed the title 行级内容备注 行级批注 Oct 11, 2021
@88250 88250 mentioned this issue Dec 23, 2021
Closed
@88250 88250 mentioned this issue Apr 13, 2022
Closed
@88250 88250 added the Feature label Sep 16, 2022
@88250 88250 added this to the 2.2.0 milestone Sep 16, 2022
@88250 88250 reopened this Sep 16, 2022
@88250 88250 changed the title 行级批注 支持行级注释 Sep 16, 2022
@aptexd
Copy link

aptexd commented Sep 17, 2022

好奇一下，行级注释通过什么方案进行锚定文本的，是字符串吗，还是特殊标记

@88250
Copy link
Member

88250 commented Sep 17, 2022

@aptexd 将选择的文本加上 <span>，类似这样：

foo<span data-type="comment" data-comment-content="这里是对 bar 的注释">bar</span>baz

@88250 88250 changed the title 支持行级注释 支持行级备注 Sep 17, 2022
@88250
Copy link
Member

88250 commented Sep 17, 2022

为了和块级备注对应，命名定为 行级备注，DOM 结构大致是：

foo<span data-type="inline-memo" data-inline-memo-content="这里是对 bar 的备注">bar</span>baz

Vanessa219 added a commit that referenced this issue Sep 17, 2022
@Vanessa219
✨ #174
4b5e19e
88250 added a commit to 88250/lute that referenced this issue Sep 17, 2022
@88250
✨ Protyle 支持行级备注 siyuan-note/siyuan#174
bd9b51d
88250 added a commit to 88250/lute that referenced this issue Sep 17, 2022
@88250
✨ Protyle 支持行级备注 siyuan-note/siyuan#174
03528fc
88250 added a commit that referenced this issue Sep 17, 2022
@88250
✨ 支持行级备注 #174
963b409
@88250 88250 moved this to 正在进行 In Progress in SiYuan Roadmap Sep 18, 2022
@88250 88250 closed this as completed Sep 18, 2022
Repository owner moved this from 正在进行 In Progress to 已经完成 Already Done in SiYuan Roadmap Sep 18, 2022
Vanessa219 added a commit that referenced this issue Sep 18, 2022
@Vanessa219
📝 #174
40868a5
88250 added a commit to 88250/lute that referenced this issue Sep 18, 2022
@88250
✨ Protyle 支持行级备注 siyuan-note/siyuan#174
bb0cfe3
88250 added a commit to 88250/lute that referenced this issue Sep 18, 2022
@88250
✨ Protyle 支持行级备注 siyuan-note/siyuan#174
47f734e
88250 added a commit to 88250/lute that referenced this issue Sep 18, 2022
@88250
✨ Protyle 支持行级备注 siyuan-note/siyuan#174
65de946
88250 added a commit that referenced this issue Sep 18, 2022
@88250
✨ 支持行级备注 #174
db8ca05
88250 added a commit that referenced this issue Sep 18, 2022
@88250
✨ 支持行级备注 #174
edfb645
Vanessa219 added a commit that referenced this issue Sep 18, 2022
@Vanessa219
🐛 #174
bab9a27
88250 added a commit to 88250/lute that referenced this issue Sep 18, 2022
@88250
✨ Protyle 支持行级备注 siyuan-note/siyuan#174
18adc92
88250 added a commit that referenced this issue Sep 18, 2022
@88250
✨ 支持行级备注 #174
270c207
@88250 88250 removed this from SiYuan Roadmap Sep 21, 2022
leolee9086 pushed a commit to leolee9086/siyuan that referenced this issue Oct 4, 2022
@Vanessa219 @leolee9086
✨ siyuan-note#174
5fd7730
leolee9086 pushed a commit to leolee9086/siyuan that referenced this issue Oct 4, 2022
@88250 @leolee9086
✨ 支持行级备注 siyuan-note#174
295a4d1
leolee9086 pushed a commit to leolee9086/siyuan that referenced this issue Oct 4, 2022
@Vanessa219 @leolee9086
📝 siyuan-note#174
be4da0c
leolee9086 pushed a commit to leolee9086/siyuan that referenced this issue Oct 4, 2022
@Vanessa219 @leolee9086
🐛 siyuan-note#174
ebd65a8
leolee9086 pushed a commit to leolee9086/siyuan that referenced this issue Oct 4, 2022
@88250 @leolee9086
✨ 支持行级备注 siyuan-note#174
63680e9
leolee9086 pushed a commit to leolee9086/siyuan that referenced this issue Oct 4, 2022
@88250 @leolee9086
✨ 支持行级备注 siyuan-note#174
5f624ee
leolee9086 pushed a commit to leolee9086/siyuan that referenced this issue Oct 4, 2022
@88250 @leolee9086
✨ 支持行级备注 siyuan-note#174
eacabd9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@88250 88250

@Vanessa219 Vanessa219

Labels
Feature
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
4 participants
@88250 @Vanessa219 @aptexd @lvzhp