Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

支持自动生成端到端加密密码 #3790

Closed
88250 opened this issue Jan 10, 2022 · 7 comments
Closed

支持自动生成端到端加密密码 #3790

88250 opened this issue Jan 10, 2022 · 7 comments
Assignees
Labels
Milestone

Comments

@88250
Copy link
Member

88250 commented Jan 10, 2022

https://ld246.com/article/1641732887291

在设置端到端加密密码前让用户选择:

  • 自动生成
  • 自定义

自动生成的密码是根据 user id 生成的。

@88250 88250 added the Feature label Jan 10, 2022
@88250 88250 added this to the 1.7.0 milestone Jan 10, 2022
@88250 88250 changed the title 云端托管的端到端密码 支持自动生成的端到端密码 Jan 10, 2022
@88250 88250 changed the title 支持自动生成的端到端密码 支持自动生成的端到端加密密码 Jan 10, 2022
Vanessa219 added a commit to siyuan-note/appearance that referenced this issue Jan 10, 2022
88250 added a commit to siyuan-note/user-guide-zh_CN that referenced this issue Jan 10, 2022
88250 added a commit to siyuan-note/user-guide-en_US that referenced this issue Jan 10, 2022
88250 added a commit to siyuan-note/user-guide-zh_CHT that referenced this issue Jan 10, 2022
88250 added a commit to siyuan-note/appearance that referenced this issue Jan 10, 2022
88250 added a commit to siyuan-note/appearance that referenced this issue Jan 10, 2022
@88250 88250 changed the title 支持自动生成的端到端加密密码 支持自动生成端到端加密密码 Jan 10, 2022
@aptexd
Copy link

aptexd commented Jan 10, 2022

看贴子说是支持云端托管,看这个issue应该是本地生成的
我想如果云端托管最多可以托管一句提示语
不建议这个密码上云,如果上云这会是一个很大的问题

@88250
Copy link
Member Author

88250 commented Jan 10, 2022

@aptexd 云端不保存的,而是基于 user id 通过一个 hash 算法在本地生成作为密码。

Vanessa219 added a commit to siyuan-note/appearance that referenced this issue Jan 10, 2022
88250 added a commit to siyuan-note/appearance that referenced this issue Jan 10, 2022
@ProgramFan
Copy link

想问一句, user id 本地 hash 加盐了吧?不然云上不安全啊。我觉得D大肯定会想到这个,但还是想问一问。

@ProgramFan
Copy link

如果本地加某种随机盐,在论坛里面那种情况只会更糟。如果不加,那么云端加密形同虚设(密码对云是开放的,如果hash算法也为人知,所有截获该数据流的第三方都能解密)。

@88250
Copy link
Member Author

88250 commented Jan 10, 2022

@ProgramFan 不加盐,Hash 算法写死在程序里的。所以如果选择使用自动生成密码的方式,那么实际上开发者是可以在云端解密数据的。这个看用户自己选择吧,有的用户并不需要太高的安全性,但是需要便利性。

@ProgramFan
Copy link

理解了。不开源的话,安全性还是有保障的,毕竟思源自己没有动力去解密用户数据。

@88250
Copy link
Member Author

88250 commented May 26, 2022

@ProgramFan #5013 开源以后这个问题需要注意,主要是本地环境的安全性。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants