Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

当光标移动到图表等块上时统一显示编辑和菜单按钮，取消其点击事件 #4742

Closed
UltramarineSky opened this issue Apr 30, 2022 · 1 comment
Closed

当光标移动到图表等块上时统一显示编辑和菜单按钮，取消其点击事件 #4742

UltramarineSky opened this issue Apr 30, 2022 · 1 comment
Assignees
@Vanessa219
Labels
Enhancement
Milestone
2.0.4

Comments

@UltramarineSky
Copy link

在什么情况下你需要该特性？ In what scenarios do you need this feature?

目前思源里对于图表块、html块的编辑代码功能操作逻辑不统一

  • Mermaid、五线谱、Graphviz、FlowChart、PlantUML等图表都是点击直接弹出代码编辑窗口
  • Echarts、mindmap、html块则是需要到块标菜单里选择后才能编辑

这两种编辑操作逻辑不统一，在块菜单里选择编辑按钮步骤有些繁琐。

描述可能的最优解决方案 Describe the optimal solution

sql查询嵌入块的编辑按钮一样，在图表块右上角添加编辑按钮进行代码编辑

描述候选的解决方案 Describe the candidate solution

其他信息 Other information
@Vanessa219
Copy link
Member

Vanessa219 commented Apr 30, 2022 •
edited

图标、脑图、html 的界面会有点击事件，因此目前不能和其他图标进行统一的操作。

如果都添加按钮的话，可以对 html、脑图、流程图、时序图、甘特图、类图、用户游历图、Git 图、实体关系图、图表、五线谱、Graphviz、Flowchart、PlantUML 进行统一处理。

@Vanessa219 Vanessa219 changed the title 图表块和html块添加编辑按钮 当光标移动到图表等块上时统一显示编辑和菜单按钮，取消其点击事件 Apr 30, 2022
@Vanessa219 Vanessa219 self-assigned this Apr 30, 2022
@Vanessa219 Vanessa219 added this to the backlog milestone Apr 30, 2022
88250 added a commit to 88250/lute that referenced this issue May 2, 2022
@88250
🎨 Protyle HTML 块改进 siyuan-note/siyuan#4742
af3aefd
88250 added a commit to 88250/lute that referenced this issue May 2, 2022
@88250
🎨 Protyle HTML 块改进 siyuan-note/siyuan#4742
ff77727
@Vanessa219 Vanessa219 modified the milestones: backlog, 2.0.4 May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vanessa219 Vanessa219

Labels
Enhancement
Projects
None yet
Milestone
2.0.4
Development

No branches or pull requests
3 participants
@88250 @Vanessa219 @UltramarineSky