Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search ignore case supports Unicode character folding #5398

Closed
1 task done
myownstandard opened this issue Jul 11, 2022 · 1 comment
Closed
1 task done

Search ignore case supports Unicode character folding #5398

myownstandard opened this issue Jul 11, 2022 · 1 comment
Assignees
Milestone

Comments

@myownstandard
Copy link

该问题是否已经被报告过了? Is there an existing issue for this?

  • 我已经搜索了 Issues,没有发现类似问题
    I have searched the existing issues

描述问题 Describe the problem

Hi! Sorry I don't speak Chinese. But the problem is next:
I think it's a bug of fst5 for the SQLite3 that is used for full-text-searching in the desktop app. It doesn't handle Cyrillic upper case characters well.
Maybe it can be repaired? Thank you very much!

期待的结果 Expected result

Example:
I cant find existing word "Окружающие" for example. When I am searching for that Russian word "Окружающие" it only finds if it is lower case "окружающие" in my notes.
Case sensitive search if Off.
So I need not to use Upper case words at all (so it could be found) or remember how every word was written (lower or upper case) so I could find it in the future via Search panel...

截屏或者录屏演示 Screenshot or screen recording presentation

Снимок экрана 2022-07-11 в 13 16 34

Снимок экрана 2022-07-11 в 13 16 49

版本环境 Version environment

- Version: 2.0.25
- Operating System: Mac OS Big Sur 11.6.1 and Windows 10
- Browser (if used):

日志文件 Log file

siyuan.log

更多信息 More information

No response

@88250
Copy link
Member

88250 commented Jul 12, 2022

Hello, currently we are not dealing with Unicode Folding, only ASCII character case is supported. This may take time to resolve later, thank you.

@88250 88250 changed the title Text search not working with Cyrillic upper case characters Search not working with Unicode folding Jul 12, 2022
@88250 88250 self-assigned this Jul 13, 2022
@88250 88250 changed the title Search not working with Unicode folding Search not working with Unicode case folding Jul 13, 2022
@88250 88250 added this to the 2.0.27 milestone Jul 13, 2022
@88250 88250 changed the title Search not working with Unicode case folding Search ignore case supports Unicode character folding Jul 13, 2022
@88250 88250 closed this as completed Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants