Skip to content

预览时图片等附件资源链接错误 #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Amwsup opened this issue Nov 26, 2020 · 1 comment
Closed

预览时图片等附件资源链接错误 #588

Amwsup opened this issue Nov 26, 2020 · 1 comment
Assignees
Labels
Milestone

Comments

@Amwsup
Copy link

Amwsup commented Nov 26, 2020

描述问题 Describe the problem

答:
1.上传名称中有空格的附件,[shell.pdf](assets/20201126150150-37lk8p2-shell .pdf),路径带空格,导致无效

  1. 浏览器中打开预览模式点击附件,比如ini、pdf,可能生成的路径为
    http://127.0.0.1:6806/127.0.0.1:6806/siyuan/siyuan/%E6%8A%80%E6%9C%AF/assets/20201126150823-4a3m1hw-shell.pdf 存在两个http://127.0.0.1:6806/ ,导致找不到实际文件

  2. 浏览器中打开预览模式点击附件,是在当前标签页打开,建议改成在新标签页打开,不然看完了,回退后看文章其他内容(有时打开只是阅读,不是编辑,见需求新增默认打开为阅读模式的需求 #587)还得再次点预览,造成资源消耗

  3. 客户端以及浏览器中打开,无论预览模式还是非预览模式,到处pdf,都是代码模式,而不是所见的文章模式

  • 文章
  • image
  • 生成
  • image

期待的结果 Expected result

  1. 兼容带空格的文件上传
  2. 浏览器路径避免两个IP和port
  3. 在新标签页打开附件,比如ini、txt、pdf
  4. 完善pdf导出

版本环境 Version environment

  • 版本 Version:siyuan-0.4.92-win.exe
  • 操作系统 Operating system:Windows 10
  • 浏览器(如果使用)Browser (if used):新Microsoft Edge

其他信息 Other information

@88250
Copy link
Member

88250 commented Nov 26, 2020

  1. 带空格的路径支持需要打开这个选项:设置 - 编辑器 - 支持带空格的图片链接路径
  2. 预览时路径错误的问题下个版本修复
  3. 这个估计需要手动按着 Ctrl 打开链接,如果默认新页签开的话可能不是所有人都需要
  4. PDF 导出请关注 PDF 导出 #79

感谢反馈。

@88250 88250 added the Bug label Nov 26, 2020
@88250 88250 changed the title 关于附件相关的一些缺陷报告 预览时图片等附件资源链接错误 Nov 26, 2020
@88250 88250 added this to the 0.5.0 milestone Nov 26, 2020
@88250 88250 closed this as completed Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants