Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

改进闪卡复习交互 #6928

Closed
L-M-Sherlock opened this issue Dec 27, 2022 · 14 comments
Closed

改进闪卡复习交互 #6928

L-M-Sherlock opened this issue Dec 27, 2022 · 14 comments
Assignees
Milestone

Comments

@L-M-Sherlock
Copy link
Contributor

在什么情况下你需要该特性?In what scenarios do you need this feature?

今天试了一下 2.6.0 的闪卡功能,发现点开闪卡后,还没有点 show,就可以点 again、hard、good、easy 等评分按钮。另外这些评分按钮上也没有显示下一次复习是多久之后。

image

描述可能的最优解决方案 Describe the optimal solution

参考 Anki 的实现:

点击显示答案前:

image

点击显示答案后:

image

描述候选的解决方案 Describe the candidate solution

No response

其他信息 Other information

No response

@Danielypzhang
Copy link

还有其他的改进,请考虑
没办法手动修改到期日
重要性没办法标识

@88250 88250 changed the title 闪卡功能改进 1. 在显示答案后再显示评分按钮 2. 显示每个评分对应的复习间隔 改进闪卡交互 Dec 27, 2022
@88250 88250 added this to the 2.6.1 milestone Dec 27, 2022
@wfan14513
Copy link

安卓手机端,打开菜单选了闪卡后,菜单不会消失挡住了闪卡。

88250 added a commit to siyuan-note/riff that referenced this issue Dec 28, 2022

Verified

This commit was signed with the committer’s verified signature.
baev Dmitry Baev
88250 added a commit that referenced this issue Dec 28, 2022

Verified

This commit was signed with the committer’s verified signature.
baev Dmitry Baev
@Danielypzhang
Copy link

@88250 闪卡的时间计算感觉是精确到了小时,我下午创建的闪卡,第二天上午没有显示,到了下午才有,感觉是24小时。应该是过了零点到了第二天就应该显示。

@88250
Copy link
Member

88250 commented Dec 28, 2022

@Danielypzhang 是的,这个应该没有问题。

@88250
Copy link
Member

88250 commented Dec 28, 2022

安卓手机端,打开菜单选了闪卡后,菜单不会消失挡住了闪卡。

#6935

Vanessa219 added a commit that referenced this issue Dec 29, 2022

Verified

This commit was signed with the committer’s verified signature.
baev Dmitry Baev
@88250 88250 changed the title 改进闪卡交互 改进闪卡复习交互 Dec 29, 2022
Vanessa219 added a commit that referenced this issue Dec 29, 2022

Verified

This commit was signed with the committer’s verified signature.
baev Dmitry Baev
Vanessa219 added a commit that referenced this issue Dec 29, 2022

Verified

This commit was signed with the committer’s verified signature.
baev Dmitry Baev
Vanessa219 added a commit that referenced this issue Dec 29, 2022

Verified

This commit was signed with the committer’s verified signature.
baev Dmitry Baev
@Danielypzhang
Copy link

@88250 今天又遇到了,早上没有闪卡任务,晚上才有。

@88250
Copy link
Member

88250 commented Dec 29, 2022

我感觉这个应该是正常的吧,按照算法给定的到期时间后才显示。

@Zuoqiu-Yingyi
Copy link
Contributor

2.6.1-dev3 版本点击 show 按钮后就没法再次隐藏挖空的内容了, 是不是应该在点击后保留该按钮, 并将该按钮功能更改为显示/隐藏

@88250
Copy link
Member

88250 commented Dec 30, 2022

2.6.1-dev3 版本点击 show 按钮后就没法再次隐藏挖空的内容了, 是不是应该在点击后保留该按钮, 并将该按钮功能更改为显示/隐藏

好像其他软件也是这样的。

@L-M-Sherlock
Copy link
Contributor Author

好像其他软件也是这样的。

他说大概是撤销复习的功能。

@88250
Copy link
Member

88250 commented Dec 30, 2022

这个不太确定,先这样,后面收集反馈了再看看。

@88250
Copy link
Member

88250 commented Feb 23, 2023

@L-M-Sherlock 老铁,有个问题请教一下,复习评分 go-fsrs 支持撤销吗?或者一般是如何处理评分后撤销的?

@L-M-Sherlock
Copy link
Contributor Author

@L-M-Sherlock 老铁,有个问题请教一下,复习评分 go-fsrs 支持撤销吗?或者一般是如何处理评分后撤销的?

go-fsrs 返回的是 card 和 revlog,把传入的 card 存一份,撤回的时候覆盖回去应该就行了。revlog 就直接丢掉最新的。

@88250
Copy link
Member

88250 commented Feb 23, 2023

谢谢,后面我试试看。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants