Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

为页面 html 标签添加属性 lang、data-theme-mode、data-light-theme、data-dark-theme #7259

Closed
Vanessa219 opened this issue Feb 5, 2023 · 2 comments
Closed

为页面 html 标签添加属性 lang、data-theme-mode、data-light-theme、data-dark-theme #7259

Vanessa219 opened this issue Feb 5, 2023 · 2 comments
Assignees
@Vanessa219
Labels
Enhancement
Milestone
2.7.3

Comments

@Vanessa219
Copy link
Member

No description provided.

@Vanessa219 Vanessa219 mentioned this issue Feb 5, 2023
Closed
1 task
@Vanessa219 Vanessa219 self-assigned this Feb 5, 2023
@Vanessa219 Vanessa219 added this to the 2.7.3 milestone Feb 5, 2023
@Vanessa219 Vanessa219 changed the title 为页面 html 标签添加属性 lang、data-color-mode、data-light-theme、data-dark-theme 为页面 html 标签添加属性 lang、data-theme-mode、data-light-theme、data-dark-theme Feb 5, 2023
@Vanessa219
Copy link
Member Author

#7259

Vanessa219 added a commit that referenced this issue Feb 5, 2023
@Vanessa219
🎨 fix #7259

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 136F30F901A2231D
Learn about vigilant mode
b8c9511
@Zuoqiu-Yingyi
Copy link
Contributor

@Vanessa219 当用户使用深色主题导出 PDF 时, 虽然加载了浅色主题的样式文件, 但是的预览窗口的 html 标签的 data-theme-mode 属性依然设置为了 dark, 这会导致导出预览与实际导出内容均出现异常

因此导出 PDF 的预览窗口与实际导出时 html 标签的 data-theme-mode 属性应该强制设置为 light

@Vanessa219 Vanessa219 mentioned this issue Feb 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vanessa219 Vanessa219

Labels
Enhancement
Projects
None yet
Milestone
2.7.3
Development

No branches or pull requests
2 participants
@Vanessa219 @Zuoqiu-Yingyi