Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

改进浏览器剪藏扩展转换本地图片成功率 #7464

Closed
3 tasks done
3t2ugg1e opened this issue Feb 23, 2023 · 4 comments
Closed
3 tasks done

改进浏览器剪藏扩展转换本地图片成功率 #7464

3t2ugg1e opened this issue Feb 23, 2023 · 4 comments
Assignees
@88250
Labels
Enhancement
Milestone
2.7.7

Comments

@3t2ugg1e
Copy link

该问题是否已经被报告过了？ Is there an existing issue for this?

  • 我已经搜索了 Issues，没有发现类似问题
    I have searched the existing issues

该问题是否能够在默认主题（daylight/midnight）下重现？ Can the issue be reproduced with the default theme (daylight/midnight)?

  • 我能够在默认主题下重现该问题
    I was able to reproduce the issue with the default theme

该问题是否可能是由于扩展功能导致？ Could the issue be due to extensions?

  • 我已经排除了扩展导致问题的可能性
    I've ruled out the possibility that the extension is causing the problem.

描述问题 Describe the problem

思源笔记chrome插件无法剪藏先知平台的文章。
参考链接https://xz.aliyun.com/t/12194
image
经过分析，主要问题是aliyun的图片需要refer才能访问。
image
image

期待的结果 Expected result

支持refer头

截屏或者录屏演示 Screenshot or screen recording presentation

无

版本环境 Version environment

- Version: 
- Operating System: 
- Browser (if used):
最新的思源笔记和插件

日志文件 Log file

无

更多信息 More information

无
@88250
Copy link
Member

88250 commented Feb 24, 2023

应该有两个问题：

  1. 这个站点上的图床不支持跨域请求

    image

  2. 使用后端的网络图片拉取转换报 403，应该是你分析的原因

    image

前端估计无法搞定跨域了，我们看看后端这里如何改进，谢谢。

@88250 88250 changed the title 思源笔记chrome插件无法剪藏先知平台的文章 改进浏览器剪藏扩展转换本地图片 Feb 24, 2023
@88250 88250 self-assigned this Feb 24, 2023
@88250 88250 added this to the 2.7.7 milestone Feb 24, 2023
@88250 88250 changed the title 改进浏览器剪藏扩展转换本地图片 改进浏览器剪藏扩展转换本地图片成功率 Feb 24, 2023
88250 added a commit to siyuan-note/siyuan-chrome that referenced this issue Feb 24, 2023
@88250
🎨 改进浏览器剪藏扩展转换本地图片 siyuan-note/siyuan#7464
3a91972
88250 added a commit to siyuan-note/siyuan-chrome that referenced this issue Feb 24, 2023
@88250
🎨 改进浏览器剪藏扩展转换本地图片 siyuan-note/siyuan#7464
d0c321a
88250 added a commit that referenced this issue Feb 24, 2023
@88250
🎨 改进浏览器剪藏扩展转换本地图片 #7464
ca0affb
88250 added a commit that referenced this issue Feb 24, 2023
@88250
🎨 改进浏览器剪藏扩展转换本地图片成功率 #7464
2c4b38e
@88250 88250 closed this as completed Feb 24, 2023
@Zuoqiu-Yingyi
Copy link
Contributor

Zuoqiu-Yingyi commented Feb 26, 2023 •
edited

@88250 v2.7.7-dev2 版本中, 下面超链接对应的图片无法使用 网络图片转换为本地图片 功能转换为本地图片
https://sns-img-bd.xhscdn.com/37e3ba1b-9d7d-0cbf-87f7-a77cd96fb69b?imageView2/2/w/900/format/webp

提示: 该文档中不存在网络图片

@88250
Copy link
Member

88250 commented Feb 27, 2023

@Zuoqiu-Yingyi 我这里最新开发版上测试重现不了问题，可以拉取成功。

image

@Zuoqiu-Yingyi
Copy link
Contributor

Zuoqiu-Yingyi commented Feb 27, 2023 •
edited

我这里最新开发版上测试重现不了问题，可以拉取成功。

我使用 2.7.7-dev4 版本依然不能下载, siyuan.log 中提示

E 2023/02/27 17:44:14 assets.go:148: download net img [https://sns-img-bd.xhscdn.com/37e3ba1b-9d7d-0cbf-87f7-a77cd96fb69b?imageView2/2/w/900/format/webp] failed: 403

注: 网络环境在使用 直接链接/socks5 代理/https 代理 均出现该问题

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@88250 88250

Labels
Enhancement
Projects
None yet
Milestone
2.7.7
Development

No branches or pull requests
3 participants
@88250 @Zuoqiu-Yingyi @3t2ugg1e