Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data synchronization online check not using configured endpoint #7831

Closed
3 tasks done
nekrondev opened this issue Mar 30, 2023 · 2 comments
Closed
3 tasks done

Data synchronization online check not using configured endpoint #7831

nekrondev opened this issue Mar 30, 2023 · 2 comments
Assignees
@88250
Labels
Bug
Milestone
2.8.3

Comments

@nekrondev
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Can the issue be reproduced with the default theme (daylight/midnight)?

  • I was able to reproduce the issue with the default theme

Could the issue be due to extensions?

  • I've ruled out the possibility that the extension is causing the problem.

Describe the problem

Current S3 online check is broken as configured endpoint is not used for checking but www.baidu.com instead.

Expected result

Online-check is requesting configured endpoint.

Screenshot or screen recording presentation

see

siyuan/kernel/util/net.go

Line 62 in 127feaa

_, err := c.R().Head("https://www.baidu.com")

Version environment

- Version: 2.8.2
- Operating System: Windows 10
- Browser (if used): None

Log file

W 2023/03/30 09:37:16 net.go:56: network is offline [checkURL=https://my-private-s3-endpoint.com/]

More information
@88250 88250 self-assigned this Mar 30, 2023
@88250 88250 added the Bug label Mar 30, 2023
@88250 88250 added this to the 2.8.3 milestone Mar 30, 2023
88250 added a commit that referenced this issue Mar 30, 2023
@88250
🐛 S3 synchronization online check not using configured endpoint Fix #…
4fa0c28 
…7831
@88250 88250 closed this as completed Mar 30, 2023
@88250 88250 changed the title S3 synchronization online check not using configured endpoint Data synchronization online check not using configured endpoint Mar 30, 2023
This was referenced Mar 31, 2023
Closed
Closed
88250 added a commit that referenced this issue Apr 4, 2023
@88250
🐛 S3 synchronization online check not using configured endpoint Fix #…
448ad6d 
…7831
@KarlKaijie
Copy link

从2.8.2更新到2.8.3，出现了这个问题。环境是Docker环境，Docker环境下有问题， 而在macos系统下却没有问题，S3的配置是一样的，不知为什么会出现不一样的结果
net.go:49: network is offline [checkURL=https://www.zzscloud.uk:50321/]

@88250
Copy link
Member

88250 commented Apr 7, 2023

@KarlKaijie 下个版本继续改进 #7890

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@88250 88250

Labels
Bug
Projects
None yet
Milestone
2.8.3
Development

No branches or pull requests
3 participants
@88250 @nekrondev @KarlKaijie