Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Word wrap for notification message shown #7986

Closed
3 tasks done
fenilgmehta opened this issue Apr 13, 2023 · 0 comments
Closed
3 tasks done

Word wrap for notification message shown #7986

fenilgmehta opened this issue Apr 13, 2023 · 0 comments
Assignees
@Vanessa219
Labels
Enhancement
Milestone
2.8.5

Comments

@fenilgmehta
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Can the issue be reproduced with the default theme (daylight/midnight)?

  • I was able to reproduce the issue with the default theme

Could the issue be due to extensions?

  • I've ruled out the possibility that the extension is causing the problem.

Describe the problem

The modal which is shown when newer version of Siyuan is downloaded and ready to install, the word wrap is breaking the word install. As visible in the below image, in and stall are on different lines.
image

Expected result

install should be a single word and should not be split across multiple lines

Screenshot or screen recording presentation

No response

Version environment

- Version: 2.8.2
- Operating System: Fedora 35, KDE

Log file

I believe it is not needed in this case.

More information

No response
@88250 88250 changed the title Word wrap for message shown to install newer version Word wrap for notification message shown Apr 13, 2023
@88250 88250 added this to the 2.8.5 milestone Apr 13, 2023
Vanessa219 added a commit that referenced this issue Apr 14, 2023
@Vanessa219
💄 fix #7986
2231d08
Zuoqiu-Yingyi added a commit to Zuoqiu-Yingyi/siyuan that referenced this issue Apr 15, 2023
@Zuoqiu-Yingyi
Squashed commit of the following:

Verified

This commit was signed with the committer’s verified signature.
Zuoqiu-Yingyi Yingyi / 颖逸
GPG key ID: 833DAD5428FF18A8
Verified
Learn about vigilant mode
370ed29 
commit 5f06c8c
Merge: 3e9f5a3 d22a269
Author: Vanessa <lly219@gmail.com>
Date:   Sat Apr 15 11:39:25 2023 +0800

    Merge remote-tracking branch 'origin/dev' into dev

commit 3e9f5a3
Author: Vanessa <lly219@gmail.com>
Date:   Sat Apr 15 11:39:09 2023 +0800

    :art: fix siyuan-note#8005

commit d22a269
Author: Liang Ding <d@b3log.org>
Date:   Sat Apr 15 11:26:06 2023 +0800

    :memo: Add explanation of what "SiYuan" means to the SiYuan User Guide Fix siyuan-note#8004

commit 1ad395c
Author: Vanessa <lly219@gmail.com>
Date:   Fri Apr 14 23:03:14 2023 +0800

    :rotating_light:

commit 2ee6b54
Author: Vanessa <lly219@gmail.com>
Date:   Fri Apr 14 23:02:44 2023 +0800

    :bug: fix siyuan-note#7979

commit 671f182
Author: Vanessa <lly219@gmail.com>
Date:   Fri Apr 14 22:42:21 2023 +0800

    :rotating_light:

commit 7557c77
Merge: 8680611 d79f97d
Author: Vanessa <lly219@gmail.com>
Date:   Fri Apr 14 22:26:52 2023 +0800

    Merge remote-tracking branch 'origin/dev' into dev

commit 8680611
Author: Vanessa <lly219@gmail.com>
Date:   Fri Apr 14 22:26:34 2023 +0800

    :art: fix siyuan-note#7979

commit d79f97d
Author: 绛亽 <83791825+Soltus@users.noreply.github.com>
Date:   Fri Apr 14 20:59:03 2023 +0800

    Update package.json (siyuan-note#8002)

commit 73b6ee5
Author: Liang Ding <d@b3log.org>
Date:   Fri Apr 14 20:55:59 2023 +0800

    :octocat: Security report just in English

commit ffd148e
Author: Liang Ding <d@b3log.org>
Date:   Fri Apr 14 20:54:49 2023 +0800

    :octocat: PR template just in English

commit 867852a
Author: Liang Ding <d@b3log.org>
Date:   Fri Apr 14 20:39:09 2023 +0800

    :art: Add OCR-related operations to the picture menu siyuan-note#7203

commit acffdeb
Author: Liang Ding <d@b3log.org>
Date:   Fri Apr 14 20:31:41 2023 +0800

    :art: Add OCR-related operations to the picture menu siyuan-note#7203

commit dfe0f4c
Author: Liang Ding <d@b3log.org>
Date:   Fri Apr 14 20:25:58 2023 +0800

    :art: Add OCR-related operations to the picture menu siyuan-note#7203

commit 2231d08
Author: Vanessa <lly219@gmail.com>
Date:   Fri Apr 14 20:21:09 2023 +0800

    :lipstick: fix siyuan-note#7986

commit b15cfb0
Merge: a339747 de440b8
Author: Vanessa <lly219@gmail.com>
Date:   Fri Apr 14 20:10:02 2023 +0800

    Merge remote-tracking branch 'origin/dev' into dev

commit a339747
Author: Vanessa <lly219@gmail.com>
Date:   Fri Apr 14 20:09:44 2023 +0800

    :art: fix siyuan-note#7982

commit de440b8
Author: Liang Ding <d@b3log.org>
Date:   Fri Apr 14 20:05:36 2023 +0800

    :arrow_up: Upgrade PNPM version

commit 6d7d8a8
Author: Liang Ding <d@b3log.org>
Date:   Fri Apr 14 20:02:24 2023 +0800

    :art: Reduce holding time of open user guide tip

commit 35c954d
Author: Liang Ding <d@b3log.org>
Date:   Fri Apr 14 20:02:07 2023 +0800

    :art: Reduce holding time of open user guide tip

commit dd2a1b2
Author: Vanessa <lly219@gmail.com>
Date:   Fri Apr 14 16:51:54 2023 +0800

    :art: siyuan-note#7203

commit c2ca60c
Merge: 7d8f725 28f3920
Author: Vanessa <lly219@gmail.com>
Date:   Fri Apr 14 16:44:56 2023 +0800

    Merge remote-tracking branch 'origin/dev' into dev

commit 7d8f725
Author: Vanessa <lly219@gmail.com>
Date:   Fri Apr 14 16:44:42 2023 +0800

    :art: siyuan-note#7954

commit 28f3920
Author: 颖逸 <49649786+Zuoqiu-Yingyi@users.noreply.github.com>
Date:   Fri Apr 14 16:38:35 2023 +0800

    :art: fix siyuan-note#7921 (siyuan-note#7997)

commit 862d0db
Author: Liang Ding <d@b3log.org>
Date:   Fri Apr 14 16:36:04 2023 +0800

    :art: Spaced repetition interface supports review by document selection siyuan-note#7954

commit 4529221
Author: Vanessa <lly219@gmail.com>
Date:   Fri Apr 14 16:32:52 2023 +0800

    :art: siyuan-note#7954

commit e7091c3
Merge: e4a77c9 d7bea02
Author: Vanessa <lly219@gmail.com>
Date:   Fri Apr 14 16:27:43 2023 +0800

    Merge remote-tracking branch 'origin/dev' into dev

commit e4a77c9
Author: Vanessa <lly219@gmail.com>
Date:   Fri Apr 14 16:27:28 2023 +0800

    :art: siyuan-note#7954
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vanessa219 Vanessa219

Labels
Enhancement
Projects
None yet
Milestone
2.8.5
Development

No branches or pull requests
3 participants
@88250 @Vanessa219 @fenilgmehta