Skip to content

Release the related resources when uninstalling the plugin #8258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
frostime opened this issue May 15, 2023 · 1 comment
Closed

Release the related resources when uninstalling the plugin #8258

frostime opened this issue May 15, 2023 · 1 comment
Assignees
@Vanessa219
Labels
Enhancement
Milestone
2.8.8

Comments

@frostime
Copy link
Contributor

In what scenarios do you need this feature?

前端提供了 openTab 但是没有提供关闭 tab 的 api。这就导致了如果没有手动关闭标签页就 disable 插件，原本的页签会一片空白。

image

Describe the optimal solution

希望提供 closeTab api，让插件可以在 unload 的时候自己关闭自己的 tab。

Describe the candidate solution

No response

Other information

No response
@Vanessa219
Copy link
Member

这个由思源本体来解决吧

@Vanessa219 Vanessa219 changed the title 提供前端 API: closeTab Uninstall the plugin, remove its tab May 15, 2023
@Vanessa219 Vanessa219 self-assigned this May 15, 2023
@Vanessa219 Vanessa219 added this to the 2.8.8 milestone May 15, 2023
@Vanessa219 Vanessa219 changed the title Uninstall the plugin, remove its tab Uninstall the plugin, remove its tab, top bar icon and dock May 15, 2023
@Vanessa219 Vanessa219 changed the title Uninstall the plugin, remove its tab, top bar icon and dock Uninstall the plugin, remove its tab, eventBus, top bar icon and dock May 15, 2023
Vanessa219 added a commit that referenced this issue May 15, 2023
@Vanessa219
🎨 fix #8258

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 136F30F901A2231D
Learn about vigilant mode
1ac623e
@88250 88250 changed the title Uninstall the plugin, remove its tab, eventBus, top bar icon and dock Release the related resources when uninstalling the plugin May 16, 2023
Zuoqiu-Yingyi added a commit to Zuoqiu-Yingyi/siyuan that referenced this issue May 16, 2023
@Zuoqiu-Yingyi
Squashed commit of the following:
946357c 
commit a335101
Author: Liang Ding <d@b3log.org>
Date:   Tue May 16 12:53:33 2023 +0800

    :bookmark: Release v2.8.8

commit 6a6dec0
Author: Liang Ding <d@b3log.org>
Date:   Tue May 16 11:30:33 2023 +0800

    :memo: Update changelogs

commit a819656
Author: Liang Ding <d@b3log.org>
Date:   Tue May 16 11:15:53 2023 +0800

    :memo: Update changelogs

commit 56a2c36
Author: Liang Ding <d@b3log.org>
Date:   Tue May 16 11:11:54 2023 +0800

    :bug: Remove inconsistent scroll IAL

commit 8b6abec
Author: Liang Ding <d@b3log.org>
Date:   Tue May 16 10:39:48 2023 +0800

    :art: Bazaar resource directories support symlink siyuan-note#8263

commit 9455086
Author: Liang Ding <d@b3log.org>
Date:   Tue May 16 10:35:46 2023 +0800

    :memo: Update changelogs

commit fdbfe6b
Author: 颖逸 <49649786+Zuoqiu-Yingyi@users.noreply.github.com>
Date:   Tue May 16 10:34:38 2023 +0800

    Bazaar resource directories support symlink (siyuan-note#8263)

    * 🎨 bazaar resource directories support symlink

    * 🎨 bazaar resource directories support symlink

commit 8549634
Author: Vanessa <lly219@gmail.com>
Date:   Tue May 16 10:31:01 2023 +0800

    :sparkles: enable plugin

commit f3d1acd
Author: Liang Ding <d@b3log.org>
Date:   Tue May 16 09:39:01 2023 +0800

    :memo: Update changelogs

commit bf4b88a
Author: Liang Ding <d@b3log.org>
Date:   Tue May 16 09:38:50 2023 +0800

    :art: Plugin hot load

commit 516276d
Author: Liang Ding <d@b3log.org>
Date:   Tue May 16 09:09:31 2023 +0800

    :art: Data sync connectivity check supports redirection Fix siyuan-note#8264

commit d24f5ae
Author: Vanessa <lly219@gmail.com>
Date:   Tue May 16 00:05:18 2023 +0800

    :rotating_light:

commit 1ac623e
Author: Vanessa <lly219@gmail.com>
Date:   Tue May 16 00:04:25 2023 +0800

    :art: fix siyuan-note#8258

commit fdf9f0d
Author: Vanessa <lly219@gmail.com>
Date:   Mon May 15 22:33:36 2023 +0800

    :art: siyuan-note#5066 removeData

commit 7c7f3db
Author: Vanessa <lly219@gmail.com>
Date:   Mon May 15 22:26:11 2023 +0800

    :bug: fix siyuan-note#8259

commit ba4e5e8
Author: Vanessa <lly219@gmail.com>
Date:   Mon May 15 19:59:13 2023 +0800

    :lipstick: fix siyuan-note#8260

commit 4f099bd
Merge: b892fad 856c7e0
Author: Vanessa <lly219@gmail.com>
Date:   Mon May 15 19:35:33 2023 +0800

    Merge remote-tracking branch 'origin/dev' into dev

commit b892fad
Author: Vanessa <lly219@gmail.com>
Date:   Mon May 15 19:35:19 2023 +0800

    :lipstick:

commit 856c7e0
Author: Liang Ding <d@b3log.org>
Date:   Mon May 15 18:48:33 2023 +0800

    :memo: Improve initialization data sync interaction siyuan-note#8220

commit ab6cb33
Author: Liang Ding <d@b3log.org>
Date:   Mon May 15 18:41:51 2023 +0800

    :memo: Improve initialization data sync interaction siyuan-note#8220

commit a759936
Author: Liang Ding <d@b3log.org>
Date:   Mon May 15 16:02:58 2023 +0800

    :memo: Improve initialization data sync interaction siyuan-note#8220

commit 2513cbc
Author: Liang Ding <d@b3log.org>
Date:   Mon May 15 15:53:46 2023 +0800

    :memo: Improve initialization data sync interaction siyuan-note#8220

commit 9a03f1e
Author: Liang Ding <d@b3log.org>
Date:   Mon May 15 15:52:00 2023 +0800

    :memo: Update changelogs

commit 4cb9523
Author: Vanessa <lly219@gmail.com>
Date:   Mon May 15 15:51:31 2023 +0800

    :art: siyuan-note#8220

commit 7d58ab0
Merge: 6ca6817 0a10285
Author: Vanessa <lly219@gmail.com>
Date:   Mon May 15 15:43:33 2023 +0800

    Merge remote-tracking branch 'origin/dev' into dev

commit 6ca6817
Author: Vanessa <lly219@gmail.com>
Date:   Mon May 15 15:43:16 2023 +0800

    :art: siyuan-note#8220

commit 0a10285
Author: Liang Ding <d@b3log.org>
Date:   Mon May 15 14:56:12 2023 +0800

    :art: Escape the notification message siyuan-note#7811

commit 7dbfa43
Author: Vanessa <lly219@gmail.com>
Date:   Mon May 15 13:59:50 2023 +0800

    :art: siyuan-note#8220

commit 15141dd
Author: Vanessa <lly219@gmail.com>
Date:   Mon May 15 13:54:30 2023 +0800

    :art: siyuan-note#8220

commit dc1941d
Author: Vanessa <lly219@gmail.com>
Date:   Mon May 15 12:11:45 2023 +0800

    :art: catch plugin load

commit e728818
Author: Vanessa <lly219@gmail.com>
Date:   Mon May 15 12:04:22 2023 +0800

    :art: catch plugin load

commit 6690084
Author: Vanessa <lly219@gmail.com>
Date:   Mon May 15 11:46:51 2023 +0800

    :art: fix siyuan-note#8256

commit 53a95ff
Author: Vanessa <lly219@gmail.com>
Date:   Mon May 15 00:27:27 2023 +0800

    :lipstick: account

commit 4c7fe24
Merge: 3674e83 2cf8a81
Author: Vanessa <lly219@gmail.com>
Date:   Mon May 15 00:11:08 2023 +0800

    Merge remote-tracking branch 'origin/dev' into dev

commit 3674e83
Author: Vanessa <lly219@gmail.com>
Date:   Mon May 15 00:10:46 2023 +0800

    :lipstick: account

commit 2cf8a81
Author: Liang Ding <d@b3log.org>
Date:   Sun May 14 23:21:32 2023 +0800

    :art: Improve images render in the marketplace package siyuan-note/bazaar#1119

commit 7572db4
Author: Vanessa <lly219@gmail.com>
Date:   Sun May 14 12:10:47 2023 +0800

    :art: fix siyuan-note#8216

commit 1807163
Author: Vanessa <lly219@gmail.com>
Date:   Sun May 14 12:09:52 2023 +0800

    :art: fix siyuan-note#8216

commit 300a60a
Merge: 0b00159 a6ecb98
Author: Vanessa <lly219@gmail.com>
Date:   Sun May 14 11:50:55 2023 +0800

    Merge remote-tracking branch 'origin/dev' into dev

commit 0b00159
Author: Vanessa <lly219@gmail.com>
Date:   Sun May 14 11:50:41 2023 +0800

    :bug: open new window

commit a6ecb98
Author: Liang Ding <d@b3log.org>
Date:   Sun May 14 11:43:54 2023 +0800

    :art: Sponsorship through the Open Collective is no longer supported

commit 6c3c8d4
Author: Liang Ding <d@b3log.org>
Date:   Sun May 14 10:44:39 2023 +0800

    :art: When multiple windows exist, each window should be isolated using the `Optimize Typesetting` siyuan-note#8216

commit 3edd823
Author: Vanessa <lly219@gmail.com>
Date:   Sun May 14 10:34:48 2023 +0800

    :art: siyuan-note#8216

commit f8412a4
Author: Vanessa <lly219@gmail.com>
Date:   Sun May 14 10:27:16 2023 +0800

    :bug: fix siyuan-note#8187

commit a74ee34
Author: Vanessa <lly219@gmail.com>
Date:   Sun May 14 10:17:43 2023 +0800

    :art: fix siyuan-note#8242

commit 518ce94
Author: Vanessa <lly219@gmail.com>
Date:   Sun May 14 10:09:11 2023 +0800

    :lipstick: bazaar

commit e6923bd
Author: Vanessa <lly219@gmail.com>
Date:   Sun May 14 09:55:50 2023 +0800

    :art: https://github.com/siyuan-note/siyuan/issues/8245?utm_source=ld246.com
88250 pushed a commit that referenced this issue May 17, 2023
@Zuoqiu-Yingyi
🎨 Widgets search supports symlink subdirectory
08b3335 
* 🎨 bazaar resource directories support symlink

* 🎨 bazaar resource directories support symlink

* Squashed commit of the following:

commit a335101
Author: Liang Ding <d@b3log.org>
Date:   Tue May 16 12:53:33 2023 +0800

    :bookmark: Release v2.8.8

commit 6a6dec0
Author: Liang Ding <d@b3log.org>
Date:   Tue May 16 11:30:33 2023 +0800

    :memo: Update changelogs

commit a819656
Author: Liang Ding <d@b3log.org>
Date:   Tue May 16 11:15:53 2023 +0800

    :memo: Update changelogs

commit 56a2c36
Author: Liang Ding <d@b3log.org>
Date:   Tue May 16 11:11:54 2023 +0800

    :bug: Remove inconsistent scroll IAL

commit 8b6abec
Author: Liang Ding <d@b3log.org>
Date:   Tue May 16 10:39:48 2023 +0800

    :art: Bazaar resource directories support symlink #8263

commit 9455086
Author: Liang Ding <d@b3log.org>
Date:   Tue May 16 10:35:46 2023 +0800

    :memo: Update changelogs

commit fdbfe6b
Author: 颖逸 <49649786+Zuoqiu-Yingyi@users.noreply.github.com>
Date:   Tue May 16 10:34:38 2023 +0800

    Bazaar resource directories support symlink (#8263)

    * 🎨 bazaar resource directories support symlink

    * 🎨 bazaar resource directories support symlink

commit 8549634
Author: Vanessa <lly219@gmail.com>
Date:   Tue May 16 10:31:01 2023 +0800

    :sparkles: enable plugin

commit f3d1acd
Author: Liang Ding <d@b3log.org>
Date:   Tue May 16 09:39:01 2023 +0800

    :memo: Update changelogs

commit bf4b88a
Author: Liang Ding <d@b3log.org>
Date:   Tue May 16 09:38:50 2023 +0800

    :art: Plugin hot load

commit 516276d
Author: Liang Ding <d@b3log.org>
Date:   Tue May 16 09:09:31 2023 +0800

    :art: Data sync connectivity check supports redirection Fix #8264

commit d24f5ae
Author: Vanessa <lly219@gmail.com>
Date:   Tue May 16 00:05:18 2023 +0800

    :rotating_light:

commit 1ac623e
Author: Vanessa <lly219@gmail.com>
Date:   Tue May 16 00:04:25 2023 +0800

    :art: fix #8258

commit fdf9f0d
Author: Vanessa <lly219@gmail.com>
Date:   Mon May 15 22:33:36 2023 +0800

    :art: #5066 removeData

commit 7c7f3db
Author: Vanessa <lly219@gmail.com>
Date:   Mon May 15 22:26:11 2023 +0800

    :bug: fix #8259

commit ba4e5e8
Author: Vanessa <lly219@gmail.com>
Date:   Mon May 15 19:59:13 2023 +0800

    :lipstick: fix #8260

commit 4f099bd
Merge: b892fad 856c7e0
Author: Vanessa <lly219@gmail.com>
Date:   Mon May 15 19:35:33 2023 +0800

    Merge remote-tracking branch 'origin/dev' into dev

commit b892fad
Author: Vanessa <lly219@gmail.com>
Date:   Mon May 15 19:35:19 2023 +0800

    :lipstick:

commit 856c7e0
Author: Liang Ding <d@b3log.org>
Date:   Mon May 15 18:48:33 2023 +0800

    :memo: Improve initialization data sync interaction #8220

commit ab6cb33
Author: Liang Ding <d@b3log.org>
Date:   Mon May 15 18:41:51 2023 +0800

    :memo: Improve initialization data sync interaction #8220

commit a759936
Author: Liang Ding <d@b3log.org>
Date:   Mon May 15 16:02:58 2023 +0800

    :memo: Improve initialization data sync interaction #8220

commit 2513cbc
Author: Liang Ding <d@b3log.org>
Date:   Mon May 15 15:53:46 2023 +0800

    :memo: Improve initialization data sync interaction #8220

commit 9a03f1e
Author: Liang Ding <d@b3log.org>
Date:   Mon May 15 15:52:00 2023 +0800

    :memo: Update changelogs

commit 4cb9523
Author: Vanessa <lly219@gmail.com>
Date:   Mon May 15 15:51:31 2023 +0800

    :art: #8220

commit 7d58ab0
Merge: 6ca6817 0a10285
Author: Vanessa <lly219@gmail.com>
Date:   Mon May 15 15:43:33 2023 +0800

    Merge remote-tracking branch 'origin/dev' into dev

commit 6ca6817
Author: Vanessa <lly219@gmail.com>
Date:   Mon May 15 15:43:16 2023 +0800

    :art: #8220

commit 0a10285
Author: Liang Ding <d@b3log.org>
Date:   Mon May 15 14:56:12 2023 +0800

    :art: Escape the notification message #7811

commit 7dbfa43
Author: Vanessa <lly219@gmail.com>
Date:   Mon May 15 13:59:50 2023 +0800

    :art: #8220

commit 15141dd
Author: Vanessa <lly219@gmail.com>
Date:   Mon May 15 13:54:30 2023 +0800

    :art: #8220

commit dc1941d
Author: Vanessa <lly219@gmail.com>
Date:   Mon May 15 12:11:45 2023 +0800

    :art: catch plugin load

commit e728818
Author: Vanessa <lly219@gmail.com>
Date:   Mon May 15 12:04:22 2023 +0800

    :art: catch plugin load

commit 6690084
Author: Vanessa <lly219@gmail.com>
Date:   Mon May 15 11:46:51 2023 +0800

    :art: fix #8256

commit 53a95ff
Author: Vanessa <lly219@gmail.com>
Date:   Mon May 15 00:27:27 2023 +0800

    :lipstick: account

commit 4c7fe24
Merge: 3674e83 2cf8a81
Author: Vanessa <lly219@gmail.com>
Date:   Mon May 15 00:11:08 2023 +0800

    Merge remote-tracking branch 'origin/dev' into dev

commit 3674e83
Author: Vanessa <lly219@gmail.com>
Date:   Mon May 15 00:10:46 2023 +0800

    :lipstick: account

commit 2cf8a81
Author: Liang Ding <d@b3log.org>
Date:   Sun May 14 23:21:32 2023 +0800

    :art: Improve images render in the marketplace package siyuan-note/bazaar#1119

commit 7572db4
Author: Vanessa <lly219@gmail.com>
Date:   Sun May 14 12:10:47 2023 +0800

    :art: fix #8216

commit 1807163
Author: Vanessa <lly219@gmail.com>
Date:   Sun May 14 12:09:52 2023 +0800

    :art: fix #8216

commit 300a60a
Merge: 0b00159 a6ecb98
Author: Vanessa <lly219@gmail.com>
Date:   Sun May 14 11:50:55 2023 +0800

    Merge remote-tracking branch 'origin/dev' into dev

commit 0b00159
Author: Vanessa <lly219@gmail.com>
Date:   Sun May 14 11:50:41 2023 +0800

    :bug: open new window

commit a6ecb98
Author: Liang Ding <d@b3log.org>
Date:   Sun May 14 11:43:54 2023 +0800

    :art: Sponsorship through the Open Collective is no longer supported

commit 6c3c8d4
Author: Liang Ding <d@b3log.org>
Date:   Sun May 14 10:44:39 2023 +0800

    :art: When multiple windows exist, each window should be isolated using the `Optimize Typesetting` #8216

commit 3edd823
Author: Vanessa <lly219@gmail.com>
Date:   Sun May 14 10:34:48 2023 +0800

    :art: #8216

commit f8412a4
Author: Vanessa <lly219@gmail.com>
Date:   Sun May 14 10:27:16 2023 +0800

    :bug: fix #8187

commit a74ee34
Author: Vanessa <lly219@gmail.com>
Date:   Sun May 14 10:17:43 2023 +0800

    :art: fix #8242

commit 518ce94
Author: Vanessa <lly219@gmail.com>
Date:   Sun May 14 10:09:11 2023 +0800

    :lipstick: bazaar

commit e6923bd
Author: Vanessa <lly219@gmail.com>
Date:   Sun May 14 09:55:50 2023 +0800

    :art: https://github.com/siyuan-note/siyuan/issues/8245?utm_source=ld246.com

* 🎨 widgets search support symlink directory

* 🎨 templates directory support symlink

* Update template.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vanessa219 Vanessa219

Labels
Enhancement
Projects
None yet
Milestone
2.8.8
Development

No branches or pull requests
2 participants
@Vanessa219 @frostime