Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace All is no longer affected by pagination #8265

Closed
3 tasks done
a15355447898a opened this issue May 15, 2023 · 6 comments
Closed
3 tasks done

Replace All is no longer affected by pagination #8265

a15355447898a opened this issue May 15, 2023 · 6 comments
Assignees
@88250 @Vanessa219
Labels
Enhancement
Milestone
2.9.4

Comments

@a15355447898a
Copy link
Contributor

a15355447898a commented May 15, 2023 •
edited by 88250

替换的"全部替换"选项并没有实现"全部替换",只替换了匹配中的一页内容

Is there an existing issue for this?

  • I have searched the existing issues

Can the issue be reproduced with the default theme (daylight/midnight)?

  • I was able to reproduce the issue with the default theme

Could the issue be due to extensions?

  • I've ruled out the possibility that the extension is causing the problem.

Describe the problem

在使用"替换"功能时,查找到了好几页的匹配内容
image
但是在点击"全部替换"后,发现只替换了第一页的内容

Expected result

我希望"全部替换"可以真正的"全部替换",把全部的匹配项都替换了,而不是只能替换一页的内容

现在每次替换都会让siyuan重启,然后我需要重新设置查找和替换的内容,如果有多页的匹配的内容需要替换,这将会极大的降低效率

Screenshot or screen recording presentation

No response

Version environment

- Version: 2.8.7
- Operating System: fedora(使用AppImage包)
- Browser (if used):

Log file

siyuan.log

More information

No response
@88250 88250 changed the title 替换的"全部替换"选项并没有实现"全部替换",只替换了匹配中的一页内容 Replace All is no longer affected by pagination May 16, 2023
@88250 88250 assigned 88250 and Vanessa219 and unassigned 88250 and Vanessa219 May 16, 2023
@88250 88250 added this to the 2.8.9 milestone May 16, 2023
@88250 88250 removed the Enhancement label May 17, 2023
@88250 88250 removed this from the 2.8.9 milestone May 17, 2023
@88250

This comment was marked as outdated.

Sign in to view
@88250 88250 closed this as completed May 17, 2023
@zxhd863943427
Copy link
Contributor

那能否允许更改每页的数量？否则当需要替换的数量大了之后真的很烦人

@88250
Copy link
Member

88250 commented May 24, 2023

暂时不考虑改了，改太大可能会导致卡死。

@zxhd863943427
Copy link
Contributor

这只是个允许用户自定义的参数，大不了加一个提示就算了。

@88250
Copy link
Member

88250 commented May 24, 2023 •
edited

之前是允许的，但是有用户不太留意会配置很大导致卡死，所以写死要可靠点。

@88250 88250 mentioned this issue Jun 15, 2023
Closed
3 tasks
@HopeLHP
Copy link

HopeLHP commented Jun 15, 2023

如果计划保持现状的话，我认为可以在替换文本框内设置占位文本提示大家替换是有限制的，不然可能存在用户以为已经替换完成但实际没有全部完成且用户没有留意的情况。我发现这种情况还是文件夹内随机选了几个文档进行检查发现的。
image

@88250 88250 reopened this Jun 29, 2023
@88250 88250 added this to the 2.9.4 milestone Jun 29, 2023
Vanessa219 added a commit that referenced this issue Jun 29, 2023
@Vanessa219
🎨 #8265
946cc4b
Vanessa219 added a commit that referenced this issue Jun 29, 2023
@Vanessa219
🎨 #8265
3b1720b
Vanessa219 added a commit that referenced this issue Jun 29, 2023
@Vanessa219
🎨 #8265
dce9d4d
88250 added a commit that referenced this issue Jun 29, 2023
@88250
🎨 Replace All is no longer affected by pagination #8265
ecd4a58
88250 added a commit that referenced this issue Jun 29, 2023
@88250
🎨 Replace All is no longer affected by pagination #8265
fa8e910
88250 added a commit that referenced this issue Jun 29, 2023
@88250
🎨 Replace All is no longer affected by pagination #8265
c49ac89
88250 added a commit that referenced this issue Jun 29, 2023
@88250
🎨 Replace All is no longer affected by pagination #8265
d6e750e
@88250 88250 closed this as completed Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@88250 88250

@Vanessa219 Vanessa219

Labels
Enhancement
Projects
None yet
Milestone
2.9.4
Development

No branches or pull requests
5 participants
@88250 @Vanessa219 @a15355447898a @HopeLHP @zxhd863943427