Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hiding the dock fails when there is a dock plugin #8614

Closed
3 tasks done
Zuoqiu-Yingyi opened this issue Jun 25, 2023 · 2 comments
Closed
3 tasks done

Hiding the dock fails when there is a dock plugin #8614

Zuoqiu-Yingyi opened this issue Jun 25, 2023 · 2 comments
Assignees
@Vanessa219
Labels
Bug
Milestone
2.9.3

Comments

@Zuoqiu-Yingyi
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Can the issue be reproduced with the default theme (daylight/midnight)?

  • I was able to reproduce the issue with the default theme

Could the issue be due to extensions?

  • I've ruled out the possibility that the extension is causing the problem.

Describe the problem

点击左下角的 隐藏停靠栏 按钮隐藏侧边栏后, 重新加载窗口时停靠栏会再次显示
After clicking the Hide Dock button in the lower left corner to hide the sidebar, the dock will be displayed again when the window is reloaded.

Expected result

记住停靠栏的状态
Remember the state of the dock

Screenshot or screen recording presentation

No response

Version environment

- Version: 2.9.3-dev4
- Operating System: windows 11
- Browser (if used): none

Log file

无有效信息输出
No valid information output

More information

No response
@88250
Copy link
Member

88250 commented Jun 25, 2023

我这里无法重现。

布局是在退出或者系统切换窗口后获得焦点时才保存，如果没有这些条件触发，调整布局后直接重载窗口是不会保存布局的。

我先关闭了，如果还有问题请继续跟帖，谢谢 🙏

@88250 88250 closed this as completed Jun 25, 2023
@Zuoqiu-Yingyi
Copy link
Contributor Author

@88250 我定位到具体的问题了, 如果插件(例如插件示例)添加了 dock 面板, 那么该面板所在的侧边栏就无法在重新加载后隐藏, 如下所示

思源笔记-bug反馈-49

@Vanessa219 Vanessa219 reopened this Jun 26, 2023
@Vanessa219 Vanessa219 changed the title 界面重新加载后隐藏停靠栏功能失效 | The function of hiding dock fails after the interface is reloaded Hiding the dock fails when there is a dock plugin Jun 26, 2023
@Vanessa219 Vanessa219 self-assigned this Jun 26, 2023
@Vanessa219 Vanessa219 added the Bug label Jun 26, 2023
@Vanessa219 Vanessa219 added this to the 2.9.3 milestone Jun 26, 2023
Vanessa219 added a commit that referenced this issue Jun 26, 2023
@Vanessa219
🎨 fix #8614
c133426
Vanessa219 added a commit that referenced this issue Jun 26, 2023
@Vanessa219
📝 #8614
e40229d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vanessa219 Vanessa219

Labels
Bug
Projects
None yet
Milestone
2.9.3
Development

No branches or pull requests
3 participants
@88250 @Vanessa219 @Zuoqiu-Yingyi