Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight active Query criteria #8813

Closed
fenilgmehta opened this issue Jul 23, 2023 · 3 comments
Closed

Highlight active Query criteria #8813

fenilgmehta opened this issue Jul 23, 2023 · 3 comments
Assignees
Milestone

Comments

@fenilgmehta
Copy link

In what scenarios do you need this feature?

When there are multiple query criteria, it is hard to know which query criteria is active. It would be really helpful to know which one is active.
image

Describe the optimal solution

Not sure what would the ideal solution be in terms of UI/UX.

One solution I could think is to use solid background for selected query criteria and colored border (border: 2px solid var(--b3-theme-secondary)) for other query criteria. In the below image, FileName is the active query criteria, and SearchAll is non-active query criteria
image

Describe the candidate solution

No response

Other information

No response

@Vanessa219 Vanessa219 added this to the 2.9.9 milestone Aug 5, 2023
Vanessa219 added a commit that referenced this issue Aug 5, 2023
@fenilgmehta
Copy link
Author

This seems to be behaving strange. When we open the search panel, it looks like below
image

When we start typing, it changes to the following
image

Type a and stop. Default will get highlighted
Type b and stop. testing will get highlighted
...

The query criteria Default, testing and default were created in the following fashing:

  1. Open search panel
  2. Click Remove query criteria
  3. Click Save query criteria and save it as Default
  4. Click Save query criteria and save it as testing
  5. Click Save query criteria and save it as default

Another observation is that whichever query criteria is clicked, that becomes bordered style. In the below case, I clicked Default and it became bordered style, and rest have solid color filled in them. The idea suggested in the Describe the optimal solution section was the opposite - use solid color filling for selected query criteria and bordered style for the rest
image

@Vanessa219
Copy link
Member

  • When the conditions are the same, saving should be directly overwritten?
  • Highlight improvements for next version.

@fenilgmehta
Copy link
Author

Following is the behavior which I would prefer for different cases:

  1. query criteria with name N1 with conditions C1 exists, and user tries to save another query criteria with the name N2 and condition C2 --> we directly save the new query criteria
  2. issues/8913: query criteria with name N1 with conditions C1 exists, and user tries to save another query criteria with the same name N1 with conditions C2 --> we prompt the user if they would like to overwrite conditions C1 with C2
  3. This issue: query criteria with name N1 with conditions C1 exists, and user tries to save another query criteria with the name N2 but with same condition C1 --> we prompt the user if they would like to rename query criteria N1 to N2
  4. query criteria with name N1 with conditions C1 exists, and user tries to save another query criteria with the same name N1 with same conditions C1 --> inform the user that query criteria with same name and conditions already exist

I know this will complicate the logic a bit. But, I feel it will resolve the issue fully.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants