-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Emoji not rendering as expected #8910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello, this depends on system fonts, please install fonts with Emoji and try again. |
Hi @88250, just got to know that this colorful emoji rendering is not much dependent on the system fonts. Instead it is more about the unicode character being inserted.
For these characters ( for char in ['⚠', '⚠️']:
print(len(char))
for ch in char:
print(f'\t{ord(ch)}') this is the output it gives
When I asked ChatGPT about this, following is the result it gave:
So, I believe if we could modify SiYuan's emoji picker to insert Unicode character for emojis with an emoji modifier (variant selector-16) then this issue will get fixed. |
Hello, I'm not sure how you inserted the Emoji characters. My test here doesn't seem to find any problems: issue.webm |
I am doing the same as you and still facing the issue. SiYuan.Emoji.Issue.mp4What is the language set in SiYuan for you? |
My operating system is Win11 Chinese version. Please check whether the characters in the exported markdown are correct, or use developer tools to check the characters. |
When I add the character with the emoji variant, the {
"ID": "20240101183456-m3qzscy",
"Type": "NodeParagraph",
"Properties": {
"id": "20240101183456-m3qzscy",
"updated": "20240101183505"
},
"Children": [
{
"Type": "NodeText",
"Data": "⚠⚠️"
}
]
} |
It seems that there are indeed bugs somewhere, but they cannot be located at the moment. If it is convenient, you are welcome to help us find the bug from the source code. Thank you. |
If I understand the situation correctly, the character getting inserted by SiYuan's emoji picker is the same for both of us. However, the font which you are using renders that emoji character colorfully even in the absence of the emoji modifier. But, for me the default font (Arial) does not do so. Arial requires the emoji modifier to display it colorfully. If I change my font to some selected other fonts (I do not recall the names as I had done testing long time back) then the emoji renders correctly. The question is how did the emoji character with emoji modifier got used in We can say that it is not a bug. But, it would be really nice to have SiYuan's emoji picker add the emoji modifier (variant selector-16) wherever needed. I hope this helps. Thanks |
Is there an existing issue for this?
Can the issue be reproduced with the default theme (daylight/midnight)?
Could the issue be due to extensions?
Describe the problem
Emoji not showing rightly:
⚠
/⚠️
does not work in both regular form and in inline code block tooExpected result
The colorful form should be rendered
Screenshot or screen recording presentation
No response
Version environment
Log file
-
More information
No response
The text was updated successfully, but these errors were encountered: