Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save query criteria with the same name and prompt whether to overwrite #8913

Closed
3 tasks done
fenilgmehta opened this issue Aug 6, 2023 · 4 comments
Closed
3 tasks done
Assignees
Milestone

Comments

@fenilgmehta
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Can the issue be reproduced with the default theme (daylight/midnight)?

  • I was able to reproduce the issue with the default theme

Could the issue be due to extensions?

  • I've ruled out the possibility that the extension is causing the problem.

Describe the problem

  1. Open global search
  2. Click Save query criteria, use the word test, and click Confirm to save the query criteria
  3. Repeat step 2 few times
  4. Press Esc to close the search panel
    image
  5. Open global search again and now you will be able to see just one query criteria with the name test, the duplicates have vanished.
    image

Expected result

If a query criteria with the same name already exists, then:

  1. We should block the user from being able to click the Confirm button
  2. We should somehow inform or give a hint that this name cannot be used as it has already been used

Screenshot or screen recording presentation

No response

Version environment

- Version: 2.9.8

Log file

-

More information

No response

@Vanessa219
Copy link
Member

This is an overwrite operation, which allows the user to confirm whether to overwrite?

@Vanessa219 Vanessa219 added this to the 2.9.9 milestone Aug 7, 2023
@Vanessa219 Vanessa219 changed the title Can save multiple query criteria with the same name Save query criteria with the same name and prompt whether to overwrite Aug 7, 2023
Vanessa219 added a commit that referenced this issue Aug 7, 2023
@fenilgmehta
Copy link
Author

Prompting the user to confirm the overwrite is great, thanks 👍

@fenilgmehta
Copy link
Author

The confirmation prompt is only shown when we click the Confirm button. If we press Enter then it does not show up, it seems to directly overwrite the existing query criteria in that case.

Vanessa219 added a commit that referenced this issue Aug 16, 2023
@Vanessa219
Copy link
Member

Thank you, the next version will improve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants