Skip to content

Wrong count for hierarchical level tag count #8915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
fenilgmehta opened this issue Aug 6, 2023 · 4 comments
Closed
3 tasks done

Wrong count for hierarchical level tag count #8915

fenilgmehta opened this issue Aug 6, 2023 · 4 comments
Assignees
@88250
Labels
Bug
Milestone
2.10.0

Comments

@fenilgmehta
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Can the issue be reproduced with the default theme (daylight/midnight)?

  • I was able to reproduce the issue with the default theme

Could the issue be due to extensions?

  • I've ruled out the possibility that the extension is causing the problem.

Describe the problem

  1. Create tag task/testing
  2. Create tag task/testing2
  3. Refresh the tag panel. The count for task will be shown as 1
  4. Clicking the entry for task will open the search panel. But, it will show 0 results
    image

Expected result

Count for task in the tags section should be 0.

Screenshot or screen recording presentation

No response

Version environment

- Version: 2.9.8

Log file

-

More information

No response
@88250
Copy link
Member

88250 commented Aug 7, 2023

image

@88250 88250 closed this as completed Aug 7, 2023
@fenilgmehta
Copy link
Author

I agree that the search is showing results. But there are two issues:

  1. On clicking the number shown at Point A in below image, the search opens with the search text being #test# which results in 0 matching results (this is shown in Point 4 of the image under the Describe the problem section of this issue). You would have had to manually remove the trailing # to see the two results as shown in your image.
  2. Point A marked in the below image is showing the count as 1. I feel it should be 0 due to the above mentioned issue.
    image

Multiple ways to get consistency in this:
a. fix the count
b. improve the search to better handle hierarchical level tag

For the below case, what do you think should the counts be for test and testing2?
image

@88250
Copy link
Member

88250 commented Aug 8, 2023

I understand your description, there is indeed a problem. What do you think of changing it to the following?

image

image

@88250 88250 self-assigned this Aug 8, 2023
@88250 88250 added the Bug label Aug 8, 2023
@88250 88250 added this to the 2.10.0 milestone Aug 8, 2023
88250 added a commit that referenced this issue Aug 8, 2023
@88250
🐛 Wrong count for hierarchical level tag count #8915
b54c05c
@fenilgmehta
Copy link
Author

The change looks great. Thanks for the fix 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@88250 88250

Labels
Bug
Projects
None yet
Milestone
2.10.0
Development

No branches or pull requests
2 participants
@88250 @fenilgmehta