Skip to content

Stick search and open tag automatically recognize whether to open on the right according to the width of the application #8928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
liao-zh opened this issue Aug 8, 2023 · 4 comments
Assignees
Milestone

Comments

@liao-zh
Copy link

liao-zh commented Aug 8, 2023

In what scenarios do you need this feature?

Currently, pressing ctrl+shift+f or clicking on tags open a search tab in a new right panel.
However, there are a few scenarios where opening in the current tab is preferred.

  1. When the siyuan window is narrow;
  2. When I'd like to open search results or tagged documents in the current panel, without having to drag the tabs once more.

Describe the optimal solution

Offer an option in the setting that do not open the search tab in a new panel.

Describe the candidate solution

No response

Other information

No response

@Vanessa219
Copy link
Member

Maybe we can automatically identify based on the application width, what is the width of your app?

@liao-zh
Copy link
Author

liao-zh commented Aug 10, 2023

Maybe we can automatically identify based on the application width, what is the width of your app?

If switching based on the width, maybe the threshold can follow that of the setting menu (when the full size icons get switched to small ones)?

I guess what bothers me is the tag search but not the general search. For the latter, I can choose between ctrl+p or ctrl+shift+f depending on the scenario. But for the tag search, clicking on a tag always triggers a ctrl+shift+f equivalent. In addition, the global search panel can be converted to a fixed tab by a click, but the reverse does not work.

Tentative solutions:

  1. As for the tag search, provide an option in the setting such that users can choose whether to trigger ctrl+p or ctrl+shift+f.
  2. As for ctrl+shift+f, open in the current tab if the width is below a threshold, which is similar to the behavior of the setting menu.
  3. Provide a button in the fixed search tab (ctrl+shift+f) that converts it to a global search panel (ctrl+p).

@Vanessa219
Copy link
Member

Since there are too many configuration items at present, subsequent additions need to be evaluated for necessity. If the default value satisfies most users, no new configuration items will be added.

  1. To open the tag, you can use the width of the app to identify the opening on the right or the opening of the current tab
  2. Same as above
  3. No other users have mentioned this requirement, and I feel that there is no usage scenario

@liao-zh
Copy link
Author

liao-zh commented Aug 11, 2023

Since there are too many configuration items at present, subsequent additions need to be evaluated for necessity. If the default value satisfies most users, no new configuration items will be added.

  1. To open the tag, you can use the width of the app to identify the opening on the right or the opening of the current tab
  2. Same as above
  3. No other users have mentioned this requirement, and I feel that there is no usage scenario

Sounds ok!

@Vanessa219 Vanessa219 added this to the 2.10.0 milestone Aug 11, 2023
@Vanessa219 Vanessa219 changed the title Option to not open the search tab in a new panel Stick search and open tag automatically recognize whether to open on the right according to the width of the application Aug 11, 2023
Vanessa219 added a commit that referenced this issue Aug 11, 2023

Verified

This commit was signed with the committer’s verified signature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants